Message-ID: <a19dc65a-ccea-fd1b-5e0c-71b7aa8502f1@timescale.com>
Date: Tue, 29 Nov 2022 13:19:59 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Content-Language: en-US
To: mahendrakar s <mahendrakarforpg@gmail.com>,
 Andrey Chudnovsky <achudnovskij@gmail.com>
Cc: "hlinnaka@iki.fi" <hlinnaka@iki.fi>,
 "michael@paquier.xyz" <michael@paquier.xyz>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 "smilingsamay@gmail.com" <smilingsamay@gmail.com>
References: <d1b467a78e0e36ed85a09adf979d04cf124a9d4b.camel@vmware.com>
 <2f06a4aef1d5defe4b7aaec01478572e5557d32a.camel@vmware.com>
 <8a5a35b31c3f25f6b047e77def0445a60399981d.camel@vmware.com>
 <0e86fe7e3534fb05db02379fed404a2010eb1d62.camel@vmware.com>
 <4db7d3ea061f47a15fc6d865f53dd327ea2975fb.camel@vmware.com>
 <CAAWbhmiWudPQk2euOQQPPa=o14zCN9U_qLwU1pShKO4A-F9yeA@mail.gmail.com>
 <CACrwV540h9+qgz85aND7jpCcuxD_TOo+fJEg7xs1JKGLMf1N+A@mail.gmail.com>
 <CAAWbhmjiQ-X9w5CqLv__Wcfvg3oJ+hXd9807Lzi=zN9DMTpfFg@mail.gmail.com>
 <CACrwV54_euYe+v7bcLrxnje-JuM=KRX5azOcmmrXJ5qrffVZfg@mail.gmail.com>
 <CAAWbhmiR9D=OG=r9-bkiNw_Sp84qc7ti0PaWA_GWUM_t1PeS=g@mail.gmail.com>
 <CACrwV56g7ZZ9wfbQxcoX5YRdx6kx_HgJjxAM5PQoBV41jpCERw@mail.gmail.com>
 <CABkiuWqp1mog7GiUq+thfn0bqKye=QShe5aVBEVSUDPYyBWKvw@mail.gmail.com>
 <f40261a5-2efb-7851-fc63-7a5b6e00c146@timescale.com>
 <CACrwV54pf-VcL_XmDSWOHtLhiprm9nxORW5LJXocD=yCVq=knQ@mail.gmail.com>
 <CABkiuWo-7KPMZ92Jii0FLz=VmQ=2UbnsgWUCqtfuLXGzubB=tg@mail.gmail.com>
From: Jacob Champion <jchampion@timescale.com>
In-Reply-To: 
 <CABkiuWo-7KPMZ92Jii0FLz=VmQ=2UbnsgWUCqtfuLXGzubB=tg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a19dc65a-ccea-fd1b-5e0c-71b7aa8502f1%40timescale.com>
Precedence: bulk

On 11/24/22 00:20, mahendrakar s wrote:
> I had validated Github by skipping the discovery mechanism and letting
> the provider extension pass on the endpoints. This is just for
> validation purposes.
> If it needs to be supported, then need a way to send the discovery
> document from extension.

Yeah. I had originally bounced around the idea that we could send a
data:// URL, but I think that opens up problems.

You're supposed to be able to link the issuer URI with the URI you got
the configuration from, and if they're different, you bail out. If a
server makes up its own OpenID configuration, we'd have to bypass that
safety check, and decide what the risks and mitigations are... Not sure
it's worth it.

Especially if you could just lobby GitHub to, say, provide an OpenID
config. (Maybe there's a security-related reason they don't.)

--Jacob