Message-ID: <a1eb50ab-c5c5-f73b-4887-58be739d12a1@enterprisedb.com>
Date: Tue, 1 Mar 2022 19:56:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Content-Language: en-US
To: Jacob Champion <pchampion@vmware.com>,
 "rjuju123@gmail.com" <rjuju123@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 "michael@paquier.xyz" <michael@paquier.xyz>,
 "sfrost@snowman.net" <sfrost@snowman.net>
References: <793d990837ae5c06a558d58d62de9378ab525d83.camel@vmware.com>
 <YhduhD/SvIX5NnxY@paquier.xyz>
 <2e28b12b450f247d5c0994207030c862263e0297.camel@vmware.com>
 <20220224171538.jbf2cxzmhiwuinp4@jrouhaud>
 <a4d9baa0717ca924331cb1dd062788bd73bd14a4.camel@vmware.com>
 <d15d02c92a3e4bdb7cc7b96b0abfe97f213e4445.camel@vmware.com>
 <cdbcf8653e56340f73438e647ea5a26f021627ed.camel@vmware.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <cdbcf8653e56340f73438e647ea5a26f021627ed.camel@vmware.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a1eb50ab-c5c5-f73b-4887-58be739d12a1%40enterprisedb.com>
Precedence: bulk

On 25.02.22 21:19, Jacob Champion wrote:
> On Fri, 2022-02-25 at 16:28 +0000, Jacob Champion wrote:
>> Ha, opr_sanity caught my use of cstring. I'll work on a fix later
>> today.
> 
> Fixed in v3.

This patch contains no documentation.  I'm having a hard time 
understanding what the name "session_authn_id" is supposed to convey. 
The comment for the Port.authn_id field says this is the "system 
username", which sounds like a clearer terminology.