Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erW77-00068u-Mz for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 21:51:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erW75-0002tu-NX for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 21:51:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erW75-0002tk-CW for pgsql-hackers@lists.postgresql.org; Thu, 01 Mar 2018 21:51:43 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erW72-0005Ed-Qj for pgsql-hackers@postgresql.org; Thu, 01 Mar 2018 21:51:42 +0000 Received: from Davids-iMac.local (unknown [173.169.74.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id EA96C546F7; Thu, 1 Mar 2018 21:51:39 +0000 (UTC) Subject: Re: row filtering for logical replication To: Andres Freund , Erik Rijkers , Euler Taveira Cc: pgsql-hackers References: <34fa0f1d44222c4c8e2b9552e3fa423a@xs4all.nl> <20180301212756.dfju64p3este35o2@alap3.anarazel.de> From: David Steele Message-ID: Date: Thu, 1 Mar 2018 16:51:39 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180301212756.dfju64p3este35o2@alap3.anarazel.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, On 3/1/18 4:27 PM, Andres Freund wrote: > On 2018-03-01 16:27:11 +0100, Erik Rijkers wrote: >> Very, very useful. I really do hope this patch survives the >> late-arrival-cull. > > FWIW, I don't think it'd be fair or prudent. There's definitely some > issues (see e.g. Craig's reply), and I don't see why this patch'd > deserve an exemption from the "nontrivial patches shouldn't be submitted > to the last CF" policy? I'm unable to find this in the CF under the title or author name. If it didn't get entered then it is definitely out. If it does have an entry, then I agree with Andres that it should be pushed to the next CF. -- -David david@pgmasters.net