Message-ID: <a27a7d1e-7c24-4355-8e17-9ba5c61837ee@iki.fi>
Date: Wed, 2 Apr 2025 20:18:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Add sortsupport for range types and btree_gist
To: Bernd Helmle <mailings@oopsware.de>, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Michael Paquier <michael@paquier.xyz>,
 jian he <jian.universality@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <a380cfd805c37c2aa70b1083d45820e1a7cbe759.camel@oopsware.de>
 <7C9400DF-66FE-4308-BAD8-92FE3D0E55C6@yandex-team.ru>
 <0d9fbd59de15e2fc987a850c3d1f8a79a6ede825.camel@oopsware.de>
 <19c62e62c79b727d2c9a82eaeecfea5017001099.camel@oopsware.de>
 <4BADF8DD-A4D3-43AA-AA08-037F6FFA40BC@yandex-team.ru>
 <61128550659807032dd29c8c8a71674c818cbbb6.camel@oopsware.de>
 <7095B5FA-FADB-4524-B858-ECD14998710B@yandex-team.ru>
 <0176b173adfcff250543fe0aee2ef6137bd71953.camel@oopsware.de>
 <bcdf583f38e7991a374c00ad77bb3adde24d8143.camel@oopsware.de>
 <F6394698-D6BD-469A-BEC4-2D23D348A324@yandex-team.ru>
 <Z0lGG9B1gSJXEwzh@paquier.xyz>
 <78499920f1e9ed5895423e735272ca2fdb90baf6.camel@oopsware.de>
 <770DB2DA-0B56-464A-87CE-5620CF12E114@yandex-team.ru>
 <6bd891c9e3aa12baea5c938267bdb5a1e50a299e.camel@oopsware.de>
 <64d324ce2a6d535d3f0f3baeeea7b25beff82ce4.camel@oopsware.de>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <64d324ce2a6d535d3f0f3baeeea7b25beff82ce4.camel@oopsware.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a27a7d1e-7c24-4355-8e17-9ba5c61837ee%40iki.fi>
Precedence: bulk

On 11/03/2025 20:28, Bernd Helmle wrote:
> Please find a new rebased version of this patch.

Hmm, if we implement sortsupport function for GiST, we can register it 
for B-tree opfamily as well. The range comparison function has quite 
high overhead thanks to detoasting, but I'm nevertheless seeing a tiny 
speedup. I tested that with:

setup:

create table intranges (r int4range);
insert into intranges select int4range(g, g+10) from generate_series(1, 
1000000) g;
vacuum freeze intranges;

test script 'rangesort.sql':

set work_mem='100 MB';
explain analyze select r from intranges order by r;

test:

pgbench -n -f rangesort.sql -P1 postgres -t100

On my laptop, that reports avg latency of 152 ms on master, and 149 ms 
latency with the patch. Nothing to write home about, but we might as 
well take it if we have the sortsupport function for gist anyway.

So I added it for the btree opfamily too, and moved the function to 
rangetypes.c since it's not just for gist anymore. I Ccmmitted that 
part, and will start looking more closely at the remaining btree_gist 
parts now.

-- 
Heikki Linnakangas
Neon (https://neon.tech)