Message-ID: <a28aba5fa6bf1abfff96e40b6d6acff8412edb15.camel@j-davis.com>
Subject: Re: Order changes in PG16 since ICU introduction
From: Jeff Davis <pgsql@j-davis.com>
To: "Jonathan S. Katz" <jkatz@postgresql.org>, Robert Haas
	 <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Regina Obe <lr@pcorp.us>, Peter Eisentraut
	 <peter.eisentraut@enterprisedb.com>, Sandro Santilli <strk@kbt.io>, 
	pgsql-hackers@lists.postgresql.org
Date: Thu, 18 May 2023 10:55:49 -0700
In-Reply-To: <52553877-7966-e25f-6c74-a974a504250e@postgresql.org>
References: <000b01d97465$c34bbd60$49e33820$@pcorp.us>
	 <3353947.1682092131@sss.pgh.pa.us> <ZELDOktA75yYG4Z2@hst.kbt.io>
	 <533d93c5-f604-8e5f-4a48-975c08c53d59@enterprisedb.com>
	 <3365333.1682098091@sss.pgh.pa.us>
	 <002d01d97477$f0395640$d0ac02c0$@pcorp.us>
	 <3367226.1682099185@sss.pgh.pa.us>
	 <003b01d9747a$910471c0$b30d5540$@pcorp.us>
	 <3368986.1682099982@sss.pgh.pa.us>
	 <000001d9747d$066b7560$13426020$@pcorp.us>
	 <3372735.1682101425@sss.pgh.pa.us>
	 <f83f089ee1e9acd5dbbbf3353294d24e1f196e95.camel@j-davis.com>
	 <CA+TgmobxgvonJT8vO_v0k9_rgDmn0CKvTe48Z=w95rrBqC95KA@mail.gmail.com>
	 <7ee07b7d5aa4fb0b47e5657640568fdd25ba168f.camel@j-davis.com>
	 <CA+TgmoaPGx+R6mOcYQwDfqGoZxd=SncDCDt9mYjz5AD5tFd8sw@mail.gmail.com>
	 <2ffe8ffb9291b9390b9ed6c1e34b4fae8e8ce324.camel@j-davis.com>
	 <25787ec7-4c04-9a8a-d241-4dc9be0b1ba3@postgresql.org>
	 <605324592391599a7ecd522087edbd00720793b7.camel@j-davis.com>
	 <f353900f4c5777b02e9c7ef85326f1954ffeccea.camel@j-davis.com>
	 <52553877-7966-e25f-6c74-a974a504250e@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/a28aba5fa6bf1abfff96e40b6d6acff8412edb15.camel%40j-davis.com>
Precedence: bulk

On Wed, 2023-05-17 at 19:59 -0400, Jonathan S. Katz wrote:
> I did a quicker read through this time. LGTM overall. I like what you
> did with the explanations around sensitivity (now it makes sense).

Committed, thank you.

There are a few things I don't understand that would be good to
document better:

* Rules. I still don't quite understand the use case: are these for
people inventing new languages? What is a plausible use case that isn't
covered by the existing locales and collation settings? Do rules make
sense for a database default collation? Are they for language experts
only or might an ordinary developer benefit from using them?

* The collation types "phonebk", "emoji", etc.: are these variants of
particular locales, or do they make sense in multiple locales? I don't
know where they fit in or how to document them.

* I don't understand what "kc" means if "ks" is not set to "level1".

Regards,
	Jeff Davis