Message-ID: <a29b0cd9-576f-486f-ba45-5139ee33adcf@gmail.com>
Date: Fri, 28 Nov 2025 22:06:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Consistently use palloc_object() and palloc_array()
To: Chao Li <li.evan.chao@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ad0748d4-3080-436e-b0bc-ac8f86a3466a@gmail.com>
 <ED821EDD-6A1B-45B8-9005-31BCFFCB5A48@gmail.com>
Content-Language: en-US
From: David Geier <geidav.pg@gmail.com>
In-Reply-To: <ED821EDD-6A1B-45B8-9005-31BCFFCB5A48@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/a29b0cd9-576f-486f-ba45-5139ee33adcf%40gmail.com>
Precedence: bulk

Hi!

Thanks for taking a look.

On 27.11.2025 00:03, Chao Li wrote:
> 
> This is a large patch, I just take a quick look, and found that:
> 
> ```
> -		*phoned_word = palloc(sizeof(char) * strlen(word) + 1);
> +		*phoned_word = palloc_array(char, strlen(word) + 1);
> ```
> 
> And
> 
> ```
> -		params = (const char **) palloc(sizeof(char *));
> +		params = palloc_object(const char *);
> ```
> 
> Applying palloc_array and palloc_object to char type doesn’t seem to improve anything.
> 

You mean because sizeof(char) is always 1 and hence we could instead
simply write:

*phoned_word = palloc(strlen(word) + 1);
params = palloc(1);

I think the _array and _object variants are more expressive and for sure
don't make the code less readable.

--
David Geier