Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan
 (format text)
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>,
 pgsql-hackers@lists.postgresql.org, depesz@depesz.com, depesz@gmail.com
References: <07b226e6-fa49-687f-b110-b7c37572f69e@dalibo.com>
 <20200819032706.GQ17022@telsasoft.com> <20200819072133.jnmtux7qbyxywh6r@nol>
 <CAApHDvrDpJNMpXMS3SNkeUitXrZAFRZ3MrzQG6ieC7vQte6aWA@mail.gmail.com>
 <20200819090429.s7hoyyw4a6jumgkc@nol>
 <CAApHDvr0hMeEDB6HE=GE6vc2kJjCoiWe7z+CVyD9CoAUB+Cpjw@mail.gmail.com>
 <e7361ab4-5b6b-9667-e25b-04ae0b070ded@oss.nttdata.com>
 <CAApHDvqWSk5tVqY9=SwsOF03xOJyrvwoavdDoNjV+2Wk10vsuQ@mail.gmail.com>
 <5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com>
 <CAApHDvoU32j3FpVFzdf7qrMmhPwd8VTy1g5nAwkh083bWELQxA@mail.gmail.com>
 <CAOBaU_bOrsngOyYhHUZ0tVGzE9FJsB4nviBZQ7zxjehsYmsWPQ@mail.gmail.com>
 <0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com>
 <4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com>
 <b10c76ce-ae6d-85ff-b185-10b00567d4ed@oss.nttdata.com>
 <1803897.1598021621@sss.pgh.pa.us>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com>
Date: Sat, 22 Aug 2020 01:04:04 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <1803897.1598021621@sss.pgh.pa.us>
Content-Type: multipart/mixed;
 boundary="------------9334FCFD7B0557FD7A2B8EF7"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------9334FCFD7B0557FD7A2B8EF7
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2020/08/21 23:53, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> Pushed. Thanks!
> 
> Buildfarm shows this patch has got problems under
> -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12

Thanks for the report!

This happens because, in text format, whether "Planning:" line is output
varies depending on the system state. So explain_filter() should ignore
"Planning:" line. Patch attached. I'm now checking whether the patched
version works fine.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------9334FCFD7B0557FD7A2B8EF7
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="bugfix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="bugfix.patch"

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZXhwbGFpbi5vdXQgYi9z
cmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2V4cGxhaW4ub3V0CmluZGV4IGExZWU2YzY3OTIu
LmRjN2FiMmNlOGIgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZXhw
bGFpbi5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9leHBsYWluLm91dApA
QCAtMjMsNiArMjMsOSBAQCBiZWdpbgogICAgICAgICAtLSBJZ25vcmUgdGV4dC1tb2RlIGJ1
ZmZlcnMgb3V0cHV0IGJlY2F1c2UgaXQgdmFyaWVzIGRlcGVuZGluZwogICAgICAgICAtLSBv
biB0aGUgc3lzdGVtIHN0YXRlCiAgICAgICAgIENPTlRJTlVFIFdIRU4gKGxuIH4gJyArQnVm
ZmVyczogLionKTsKKyAgICAgICAgLS0gSWdub3JlIHRleHQtbW9kZSAiUGxhbm5pbmc6IiBs
aW5lIGJlY2F1c2Ugd2hldGhlciBpdCdzIG91dHB1dAorICAgICAgICAtLSB2YXJpZXMgZGVw
ZW5kaW5nIG9uIHRoZSBzeXN0ZW0gc3RhdGUKKyAgICAgICAgQ09OVElOVUUgV0hFTiAobG4g
PSAnUGxhbm5pbmc6Jyk7CiAgICAgICAgIHJldHVybiBuZXh0IGxuOwogICAgIGVuZCBsb29w
OwogZW5kOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZXhwbGFpbi5zcWwg
Yi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9leHBsYWluLnNxbAppbmRleCAwMTc4M2M2MDdhLi5j
NzkxMTZjOTI3IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9leHBsYWluLnNx
bAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9leHBsYWluLnNxbApAQCAtMjUsNiArMjUs
OSBAQCBiZWdpbgogICAgICAgICAtLSBJZ25vcmUgdGV4dC1tb2RlIGJ1ZmZlcnMgb3V0cHV0
IGJlY2F1c2UgaXQgdmFyaWVzIGRlcGVuZGluZwogICAgICAgICAtLSBvbiB0aGUgc3lzdGVt
IHN0YXRlCiAgICAgICAgIENPTlRJTlVFIFdIRU4gKGxuIH4gJyArQnVmZmVyczogLionKTsK
KyAgICAgICAgLS0gSWdub3JlIHRleHQtbW9kZSAiUGxhbm5pbmc6IiBsaW5lIGJlY2F1c2Ug
d2hldGhlciBpdCdzIG91dHB1dAorICAgICAgICAtLSB2YXJpZXMgZGVwZW5kaW5nIG9uIHRo
ZSBzeXN0ZW0gc3RhdGUKKyAgICAgICAgQ09OVElOVUUgV0hFTiAobG4gPSAnUGxhbm5pbmc6
Jyk7CiAgICAgICAgIHJldHVybiBuZXh0IGxuOwogICAgIGVuZCBsb29wOwogZW5kOwo=
--------------9334FCFD7B0557FD7A2B8EF7--