Message-ID: <a2c3312f-0866-443f-a799-dd76ebf9c7f5@abcsql.com>
Date: Sun, 14 Jan 2024 14:36:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: =?UTF-8?Q?C=C3=A9dric_Villemain?= <cedric.villemain+pgsql@abcsql.com>
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
Content-Language: en-US
To: Palak Chaturvedi <chaturvedipalak1911@gmail.com>
References: <CALfch19pW48ZwWzUoRSpsaV9hqt0UPyaBPC4bOZ4W+c7FF566A@mail.gmail.com>
 <CAMm1aWbk-0C460G9ooy2yNSy1riecqvw4F7jPnqvToFZ_s4oGw@mail.gmail.com>
 <CALfch1890bL5SddyOpZDC8d-jZFOUGCGbOr+_11jLTwwJ_WEOA@mail.gmail.com>
 <CALfch1_s-X3wxeQbYxhXVuWZKBeY5YvU1D+nJxe21ri5iv0qrw@mail.gmail.com>
 <8b8c709a-c7cc-4965-8296-64f549c27501@abcsql.com>
 <3510716d-d3f3-40c8-9f7f-d644171acfb6@gmail.com>
Cc: Jim Nasby <jim.nasby@gmail.com>, pgsql-hackers@postgresql.org,
 Thomas Munro <thomas.munro@gmail.com>,
 Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Organization: Data Bene
In-Reply-To: <3510716d-d3f3-40c8-9f7f-d644171acfb6@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/a2c3312f-0866-443f-a799-dd76ebf9c7f5%40abcsql.com>
Precedence: bulk

Hi Palak,

there is currently even more interest in your patch as it should help 
building tests for on-going development around cache/read 
management/effects.

Do you expect to be able to follow-up in the coming future ?

Thank you,
Cédric

On 04/01/2024 00:15, Jim Nasby wrote:
> On 1/3/24 10:25 AM, Cédric Villemain wrote:
>> Hi Palak,
>>
>> I did a quick review of the patch:
>>
>> +CREATE FUNCTION pg_buffercache_invalidate(IN int, IN bool default true)
>> +RETURNS bool
>> +AS 'MODULE_PATHNAME', 'pg_buffercache_invalidate'
>> +LANGUAGE C PARALLEL SAFE;
>>
>> --> Not enforced anywhere, but you can also add a comment to the 
>> function, for end users...
> 
> The arguments should also have names...
> 
>>
>> +    force = PG_GETARG_BOOL(1);
>>
>> I think you also need to test PG_ARGISNULL with force parameter.
> Actually, that's true for the first argument as well. Or, just mark the 
> function as STRICT.
> 
> -- 
> Jim Nasby, Data Architect, Austin TX
> 

-- 
---
Cédric Villemain +33 (0)6 20 30 22 52
https://Data-Bene.io
PostgreSQL Expertise, Support, Training, R&D