Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on
 the fly
To: Michael Paquier <michael@paquier.xyz>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
References: <X8nLCFK4Y60UGOJb@paquier.xyz>
 <20201204192826.GA15417@alvherre.pgsql> <X8riynBLwxAD9uKk@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Alexey Kondratov <a.kondratov@postgrespro.ru>,
 Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
 Steve Singer <steve@ssinger.info>, pgsql-hackers@lists.postgresql.org,
 Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <a.korotkov@postgrespro.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Jose Luis Tallon <jltallon@adv-solutions.net>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Organization: EnterpriseDB
Message-ID: <a2e8a350-0228-6d83-e621-e57f24c54586@enterprisedb.com>
Date: Fri, 11 Dec 2020 19:17:48 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <X8riynBLwxAD9uKk@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-12-05 02:30, Michael Paquier wrote:
> On Fri, Dec 04, 2020 at 04:28:26PM -0300, Alvaro Herrera wrote:
>> FWIW I'm with Peter on this.
> 
> Okay, attached is a patch to adjust the enums for the set of utility
> commands that is the set of things I have touched lately.  Should that
> be extended more?  I have not done that as a lot of those structures
> exist as such for a long time.

I think this patch is good.

I have in the meantime committed a similar patch for cleaning up this 
issue in pg_dump.