Message-ID: <a2fc0da7-70e4-3db0-733c-0abdc1aae4ce@oss.nttdata.com>
Date: Tue, 1 Feb 2022 12:40:41 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 "Bossart, Nathan" <bossartn@amazon.com>, Julien Rouhaud
 <rjuju123@gmail.com>, Michael Paquier <michael@paquier.xyz>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CALj2ACVM4wjS+wiNZf4ssdNMhSR-XUhR99fYbV=pC9_-=5wCtw@mail.gmail.com>
 <BDAE2BB3-2F37-4B7C-A053-874250A47C21@amazon.com>
 <20220120.120029.1092463916382268628.horikyota.ntt@gmail.com>
 <CALj2ACUaGJQVbQ5Hms_C2tu+6iJX-EWkEdOiXwX1WfrxQX8pHA@mail.gmail.com>
 <20220128054620.GA654866@nathanxps13>
 <CALj2ACXWyK9DujhndkuGXb7idjL9wPJfMpzRPpM-DT1LQ6MB=Q@mail.gmail.com>
 <20220131151100.GR10577@tamriel.snowman.net>
 <CALj2ACU5NZ142kp2Bn-PK1S2G8AEENYVBfD=Cyz=fskQ6Vtf1A@mail.gmail.com>
 <20220131183009.GA660545@nathanxps13>
 <CALj2ACUaUJGvwYi4ztcc6-o2ju48BcNvayB0OuDt0-1gYHmHRw@mail.gmail.com>
 <20220201014435.GA738413@nathanxps13>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20220201014435.GA738413@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a2fc0da7-70e4-3db0-733c-0abdc1aae4ce%40oss.nttdata.com>
Precedence: bulk


On 2022/02/01 10:44, Nathan Bossart wrote:
> On Tue, Feb 01, 2022 at 12:23:10AM +0530, Bharath Rupireddy wrote:
>> On Tue, Feb 1, 2022 at 12:00 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>>> I think the pg_controldata change needs some extra spaces for alignment,
>>> but otherwise these patches seem reasonable to me.
>>
>> Thanks. My bad it was. Changed in v6.

-				(errmsg("restartpoint complete: wrote %d buffers (%.1f%%); "
+				(errmsg("restartpoint complete: lsn=%X/%X, redo lsn=%X/%X; "
+						"wrote %d buffers (%.1f%%); "
  						"%d WAL file(s) added, %d removed, %d recycled; "
  						"write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s; "
  						"sync files=%d, longest=%ld.%03d s, average=%ld.%03d s; "
  						"distance=%d kB, estimate=%d kB",
+						LSN_FORMAT_ARGS(ControlFile->checkPointCopy.redo),
+						LSN_FORMAT_ARGS(ControlFile->checkPoint),

The order of arguments for LSN seems wrong. LSN_FORMAT_ARGS(ControlFile->checkPoint) should be specified ahead of LSN_FORMAT_ARGS(ControlFile->checkPointCopy.redo)?

Could you tell me why the information for LSN is reported earlierly in the log message? Since ordinally users would be more interested in the information about I/O by checkpoint, the information for LSN should be placed later? Sorry if this was already discussed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION