public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrew Dunstan <[email protected]>
To: jian he <[email protected]>
To: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Richard Guo <[email protected]>
Subject: Re: Bug: COPY FORMAT JSON includes generated columns unlike text/CSV
Date: Wed, 15 Apr 2026 08:36:33 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxEDsyWG0-k_yQszrDw9DpOU0Rvti6EJu5kmQ26HEbHQSw@mail.gmail.com>
References: <CAHg+QDcfpGDoPL3fvfjXRtfn=fny6DdJR6BAy6TpS1Xj2EZfXA@mail.gmail.com>
	<CACJufxEDsyWG0-k_yQszrDw9DpOU0Rvti6EJu5kmQ26HEbHQSw@mail.gmail.com>


On 2026-04-14 Tu 10:46 AM, jian he wrote:
> On Mon, Apr 13, 2026 at 5:21 PM SATYANARAYANA NARLAPURAM
> <[email protected]> wrote:
>> Hi hackers,
>>
>> COPY TO with FORMAT json includes generated columns in the output,
>> while text and CSV formats correctly exclude them.  Virtual generated
>> columns appear as null (since they aren't materialized), and stored
>> generated columns appear with their values  Attached a patch to address this.
>>
> The patch looks good to me.
>
> It seems there's a ``git apply`` issue applying the V1 patch.
> The attached v2 is the same as your v1, it should apply without issue
> using `git apply` or `git am`.
>


Thanks. pushed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com


view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bug: COPY FORMAT JSON includes generated columns unlike text/CSV
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox