Subject: Re: [PATCH] Add schema and table names to partition error
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <0aa113a3-3c7f-db48-bcd8-f9290b2269ae@gmail.com>
 <CA+HiwqGRCm0HsXk_HOyWiPYbmy74QOdxQoHHohKUW1dBiFTtuw@mail.gmail.com>
 <CAA4eK1JZUxu9x0eQX7BCBGZ+9CvLr91V9OphHsSkE09jc2DQ8Q@mail.gmail.com>
 <bdeb5e60-6a86-6eeb-d073-f489bf3e8f55@gmail.com>
 <CA+HiwqE_1aDezgt4pBcUSU0UeUkowUUw-rE7faBkS07A-QtWuA@mail.gmail.com>
 <0acc36c9-1aef-1057-0c29-de473c850605@gmail.com>
 <CAA4eK1JVBuudeCY-+n6u+chYY=cyAgj1kf21eNiTG3KzjkDApA@mail.gmail.com>
 <4037ab52-27e4-bbfb-d618-adbab81125e2@gmail.com>
 <CAA4eK1J0H=4kpCVoOHzfHU62Yf=SgcCgSqqT1tGQ3BZh4yazsg@mail.gmail.com>
 <CAA4eK1+V8BjTRGkS7NTALc-5aGwq1H5OQecjSbJ3rVNXfnjEsg@mail.gmail.com>
 <53769c1d-17da-d019-8273-33db36569f44@gmail.com>
 <CAA4eK1+xv+ZGPkySPieKPnX+PR1Af0pADhdkhU9PgH3J+Khmgg@mail.gmail.com>
From: Chris Bandy <bandy.chris@gmail.com>
Message-ID: <a31fe66b-3adf-2ac4-2055-6c16bedd1302@gmail.com>
Date: Thu, 19 Mar 2020 09:51:15 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: 
 <CAA4eK1+xv+ZGPkySPieKPnX+PR1Af0pADhdkhU9PgH3J+Khmgg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/18/20 11:46 PM, Amit Kapila wrote:
> On Thu, Mar 19, 2020 at 3:55 AM Chris Bandy <bandy.chris@gmail.com> wrote:
>>
>>
>> Sorry for these troubles. Attached are patches created using `git
>> format-patch -n -v6` on master at 487e9861d0.
>>
> 
> No problem.  I have extracted your code changes as a separate patch
> (see attached) as I am not sure we want to add tests for these cases.

Patch looks good.

My last pitch to keep the tests: These would be the first and only
automated tests that verify errtable, errtableconstraint, etc.

> This doesn't apply in back-branches, but I think that is small work
> and we can do that if required.

It looks like the only failing hunk on REL_12_STABLE is in tablecmds.c.
The ereport is near line 5090 there. The partition code has changed
quite a bit compared the older branches. ;-)

Thanks,
Chris