Subject: Re: pageinspect: Hash index support
To: Ashutosh Sharma <ashu.coek88@gmail.com>
References: <e2ac6c58-b93f-9dd9-f4e6-d6d30add7fdf@redhat.com>
 <d235dcd6-146a-1269-73a0-da9a55bfeddc@redhat.com>
 <80a00b5c-56d3-dffb-8dba-edf5d2167b12@2ndquadrant.com>
 <16d89e7e-cb1a-cb5d-e944-6f10c324a312@redhat.com>
 <c982b01c-06bc-485b-5dde-057ee244261a@2ndquadrant.com>
 <836487ee-8d4e-cd49-54ac-f4793ddba5ae@redhat.com>
 <8a751498-6ee9-b943-abf3-b5641851d7de@2ndquadrant.com>
 <62ee2eba-3a5b-06d3-e224-cfe00b395be7@redhat.com>
 <f52f2117-627b-baa3-1e83-59394e881bf5@2ndquadrant.com>
 <f8a19652-c5e4-4b8f-a461-62d886ff2400@2ndquadrant.com>
 <66afc31d-e97a-41c3-da4c-bfa02fa2d54e@redhat.com>
 <eb68fb02-5a85-e643-11cf-9319dd7edf2b@2ndquadrant.com>
 <8921.1478109287@sss.pgh.pa.us>
 <7351c7bb-db87-be4a-0b86-7f7aad0bed41@2ndquadrant.com>
 <4938.1478215407@sss.pgh.pa.us>
 <CAE9k0Pn0D_8khiKvg8PGUFpGDiiBi8Ok-qzVQwqW5WJKiZSLQQ@mail.gmail.com>
 <f557d913-c0fb-2a22-b7af-1cece5108c1e@redhat.com>
 <CAE9k0PnRF_Myp56_mfcyPHWfCVTcvtqcU6UegNOn09FYaoRi8g@mail.gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        Jeff Janes <jeff.janes@gmail.com>,
        Alvaro Herrera
 <alvherre@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: JBoss, by Red Hat
Message-ID: <a34c50fe-b71f-e025-9a6b-541e440680c5@redhat.com>
Date: Thu, 5 Jan 2017 08:29:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: 
 <CAE9k0PnRF_Myp56_mfcyPHWfCVTcvtqcU6UegNOn09FYaoRi8g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hi Ashutosh,

On 01/05/2017 07:13 AM, Ashutosh Sharma wrote:
>> * Readded pageinspect--1.6.sql
>>
>> In order to have the latest pageinspect interface in 1 file, as we need
>> something to install from.
>
> I think there should be no problem even if we simply add
> pageinspect--1.5--1.6.sql file instead of removing 1.5.sql as with the
> latest changes to the create extension infrastructure in postgresql it
> automatically finds a lower version script if unable to find the
> default version script and then upgrade it to the latest version.
>
>> Removing --1.5.sql otherwise would give
>>
>> test=# CREATE EXTENSION "pageinspect";
>> ERROR:  extension "pageinspect" has no installation script nor update path
>> for version "1.6"
>
> I didn't get this. Do you mean to say that if you add 1.6.sql and do
> not remove 1.5.sql you get this error when trying to add pageinspect
> module. I didn't
> get any such error. See below,
>
> postgres=# create extension pageinspect WITH VERSION '1.6';
> CREATE EXTENSION
>

The previous patch was using pageinspect--1.5.sql as a base, and then 
uses pageinspect--1.5-1.6.sql to upgrade to version 1.6.

Removing pageinspect--1.5.sql, and adding pageinspect--1.6.sql with the 
current interface will use pageinspect--1.6.sql directly where as 
existing installations will use the upgrade scripts.

Hence I don't see a reason why we should keep pageinspect--1.5.sql 
around when we can provide a clear interface description in a 
pageinspect--1.6.sql.

> Peter has already written a test-case-[1] based on your earlier patch
> for supporting hash index with pageinspect module. Once the latest
> patch (v10) becomes stable i will share a separete patch having a
> test-case for hash index. Infact I will try to modify an already
> existing patch by Peter.
>

Ok, sounds good.

Best regards,
  Jesper


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers