Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkib4-00FvTn-RU for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Sep 2023 10:13:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qkib3-00HWH7-FF for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Sep 2023 10:13:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkib2-00HWGs-Rp for pgsql-hackers@lists.postgresql.org; Mon, 25 Sep 2023 10:13:44 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiaz-007SuV-Jl for pgsql-hackers@postgresql.org; Mon, 25 Sep 2023 10:13:44 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id C4A3560F0B; Mon, 25 Sep 2023 19:13:35 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at oss.nttdata.com MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 25 Sep 2023 19:13:35 +0900 From: torikoshia To: htamfids@gmail.com Cc: Masahiro Ikeda , Pgsql Hackers , peter@eisentraut.org Subject: Re: Make --help output fit within 80 columns per line In-Reply-To: References: <50ca8ff35a8dd8f9ec89963b503571a7@oss.nttdata.com> <3965013067e7b6195132da6c0b80a609@oss.nttdata.com> <70043684388c1a8d181cf8f3308ad3ec@oss.nttdata.com> <7ab6295d479544ae9acb926dc3e556cf@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: torikoshia@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-09-25 15:27, torikoshia wrote: > On Tue, Sep 19, 2023 at 3:23 AM Greg Sabino Mullane > wrote: > Thanks for your investigation! > >> On Fri, Sep 15, 2023 at 11:11 AM torikoshia >> wrote: >>> I do not intend to adhere to this rule(my terminals are usually >>> bigger >>> than 80 chars per line), but wouldn't it be a not bad direction to >>> use >>> 80 characters for all commands? >> >> Well, that's the question du jour, isn't it? The 80 character limit is >> based on punch cards, and really has no place in modern systems. While >> gnu systems are stuck in the past, many other ones have moved on to >> more sensible defaults: >> >> $ wget --help | wc -L >> 110 >> >> $ gcloud --help | wc -L >> 122 >> >> $ yum --help | wc -L >> 122 >> >> git is an interesting one, as they force things through a pager for >> their help, but if you look at their raw help text files, they have >> plenty of times they go past 80 when needed: >> >> $ wc -L git/Documentation/git-*.txt | sort -g | tail -20 >> 109 git-filter-branch.txt >> 109 git-rebase.txt >> 116 git-diff-index.txt >> 116 git-http-fetch.txt >> 117 git-restore.txt >> 122 git-checkout.txt >> 122 git-ls-tree.txt >> 129 git-init-db.txt >> 131 git-push.txt >> 132 git-update-ref.txt >> 142 git-maintenance.txt >> 144 git-interpret-trailers.txt >> 146 git-cat-file.txt >> 148 git-repack.txt >> 161 git-config.txt >> 162 git-notes.txt >> 205 git-stash.txt >> 251 git-submodule.txt >> >> So in summary, I think 80 is a decent soft limit, but let's not stress >> out about some lines going over that, and make a hard limit of perhaps >> 120. > > +1. It may be a good compromise. > For enforcing the hard limit, is it better to add a regression test > like patch 0001? Ugh, regression tests failed and it appears to be due to reasons related to meson. I'm going to investigate it. -- Regards, -- Atsushi Torikoshi NTT DATA Group Corporation