Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tO47h-003s0F-P7 for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Dec 2024 00:10:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tO47g-0045bG-S2 for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Dec 2024 00:10:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tO47g-0045a3-CS for pgsql-hackers@lists.postgresql.org; Thu, 19 Dec 2024 00:10:36 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tO47c-000Ujp-Fu for pgsql-hackers@postgresql.org; Thu, 19 Dec 2024 00:10:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1734567031; bh=/WjIv8jI3zX1c49AOkcYUtT5FxE8uExPtowm2Rx1Sq8=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=f07EzNOud5DqcsrkI2obvhF/h3IZ2qUoYB2zlMC27dZp1pv6jBjhHWXo4HA2CcD2/ o5qg4j+pRu8mYBJoOEqY/AkxOewBObdXyQQGAyfdAfMv8qsifc5ANoldWdcV/J9PTU lR3g3HUzUkdPuTe0JfmO9fgquDT8GQmOAIF9xTt3daI1z0HjCzLazq+1WLKEZStmOb fHPtHEFPU4YLZk7HX/5dpGtHVZq1s9SEI58lZOk51mpKcDMsW2xhfSHpTxaFl97w8w HWWB4TNvpOK5AtzTpBGOzx6WOXbKAAFVg8gjGwavfE5/OgLPVXla5fCXQkxDL7eE94 xHyPOGAgS/Few== Received: from [172.30.48.42] (unknown [172.30.48.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.melnikov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id ED3A76092B; Thu, 19 Dec 2024 03:10:30 +0300 (MSK) Message-ID: Date: Thu, 19 Dec 2024 03:10:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Change GUC hashtable to use simplehash? To: John Naylor , Jeff Davis Cc: Ants Aasma , Heikki Linnakangas , Junwang Zhao , jian he , Andres Freund , Tom Lane , Gurjeet Singh , pgsql-hackers@postgresql.org References: <3786e988-0dc6-4feb-866c-ab5215bf2394@iki.fi> <611843ead9b111c763420bd09bbcb4a330032f8b.camel@j-davis.com> <09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com> <48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com> <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> Content-Language: en-US From: "Anton A. Melnikov" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-KSMG-AntiPhishing: NotDetected, bases: 2024/12/18 22:36:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/12/18 23:06:00 #26903803 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi! Found that https://github.com/postgres/postgres/commit/0aba2554409ee3251d7558567edd114d8ed36dcc produces a valgrind error in initdb. Such a steps: CPPFLAGS="-DUSE_VALGRIND -Og" ./configure --enable-debug --enable-tap-tests --enable-cassert --with-icu make ... valgrind --quiet --exit-on-first-error=yes --error-exitcode=1 --leak-check=no --time-stamp=yes \ --gen-suppressions=all --trace-children=yes /initdb -k -D /data give an error: running bootstrap script ... ok performing post-bootstrap initialization ... ==00:00:00:01.856 967784== Conditional jump or move depends on uninitialised value(s) ==00:00:00:01.856 967784== at 0x2F41F4: fasthash_accum (hashfn_unstable.h:136) ==00:00:00:01.856 967784== by 0x2F41F4: fasthash_accum_cstring_aligned (hashfn_unstable.h:247) ==00:00:00:01.856 967784== by 0x2F41F4: fasthash_accum_cstring (hashfn_unstable.h:271) ==00:00:00:01.856 967784== by 0x2F41F4: spcachekey_hash (namespace.c:268) ==00:00:00:01.856 967784== by 0x2F479F: nsphash_lookup (simplehash.h:836) ==00:00:00:01.856 967784== by 0x2F479F: spcache_insert (namespace.c:379) ==00:00:00:01.856 967784== by 0x2F533C: cachedNamespacePath (namespace.c:4236) ==00:00:00:01.856 967784== by 0x2F5425: recomputeNamespacePath (namespace.c:4294) ==00:00:00:01.856 967784== by 0x2F5516: RelnameGetRelid (namespace.c:875) ==00:00:00:01.856 967784== by 0x2F6CD5: RangeVarGetRelidExtended (namespace.c:524) ==00:00:00:01.856 967784== by 0x2DD1C7: objectNamesToOids (aclchk.c:701) ==00:00:00:01.856 967784== by 0x2E2A9D: ExecuteGrantStmt (aclchk.c:441) ==00:00:00:01.856 967784== by 0x61FF62: ProcessUtilitySlow (utility.c:1816) ==00:00:00:01.856 967784== by 0x61E948: standard_ProcessUtility (utility.c:973) ==00:00:00:01.856 967784== by 0x61EC1A: ProcessUtility (utility.c:530) ==00:00:00:01.856 967784== by 0x61C059: PortalRunUtility (pquery.c:1158) ==00:00:00:01.856 967784== { Memcheck:Cond fun:fasthash_accum fun:fasthash_accum_cstring_aligned fun:fasthash_accum_cstring fun:spcachekey_hash fun:nsphash_lookup fun:spcache_insert fun:cachedNamespacePath fun:recomputeNamespacePath fun:RelnameGetRelid fun:RangeVarGetRelidExtended fun:objectNamesToOids fun:ExecuteGrantStmt fun:ProcessUtilitySlow fun:standard_ProcessUtility fun:ProcessUtility fun:PortalRunUtility } ==00:00:00:01.856 967784== ==00:00:00:01.856 967784== Exit program on first error (--exit-on-first-error=yes) child process exited with exit code 1 The current master at b7493e1 also has this error. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company