Message-ID: <a3f02689-fd8b-e290-2e62-9f7a5eb6f4d8@gmail.com>
Date: Fri, 5 May 2023 09:46:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
Content-Language: en-US
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, "Yu Shi (Fujitsu)"
 <shiy.fnst@fujitsu.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <2fefa454-5a70-2174-ddbf-4a0e41537139@gmail.com>
 <9ab1827c-9a57-8c48-59b2-c5fb62c21be3@gmail.com>
 <CAA4eK1KVoAjzT49BwKCih0A+1PE7hm=4PwQ-_VUr9YteFJRB5g@mail.gmail.com>
 <CAA4eK1JeAZ9MUf3qPAOA5t9=e_vPJSEi6nZ3OygDYi-913eO+Q@mail.gmail.com>
 <74f80bc1-6b39-b2a8-c716-98beefb75e0b@gmail.com>
 <OSZPR01MB6310F24417BDD04731BD7978FD659@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <17b6b056-4f53-c444-0c94-869547d1a5df@gmail.com>
 <CAA4eK1JiYisk1aqn1uvjd+VCfsVtXLby7uMmkLQU_ggAx7xt6w@mail.gmail.com>
 <054defef-de15-53e4-6c5a-d16ccc21d4ba@gmail.com>
 <CAA4eK1LEQfC-ZxOkN4=cuAxB1N=2iLcEEb+Mb=XGCqGhwvMkaA@mail.gmail.com>
 <8a13f0d8-71f3-773b-7135-5974fd53724b@gmail.com>
 <CAA4eK1+FhvUm6w-TYqXAAMNDPZcin05pyCu7Lzn-AnafFYYhBg@mail.gmail.com>
 <CALDaNm3GOW-7DfdqUiJADhEmQNQkFA+OonV4kvKkZcbK=0yr5w@mail.gmail.com>
 <CAA4eK1La2uVZdSNdp_AwpxVP85SvWHMT3ecfJgVYqPMjGVViyw@mail.gmail.com>
 <6711e200-0d5c-98c3-ba39-7d64a6936f7a@gmail.com>
 <CAA4eK1LQmnSroXZcR+w1JuHsOyQLdj=-QWUw8ExYem3kUpBE3A@mail.gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: 
 <CAA4eK1LQmnSroXZcR+w1JuHsOyQLdj=-QWUw8ExYem3kUpBE3A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/a3f02689-fd8b-e290-2e62-9f7a5eb6f4d8%40gmail.com>
Precedence: bulk


On 5/5/23 9:04 AM, Amit Kapila wrote:
> On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> On 5/4/23 6:43 AM, Amit Kapila wrote:
>>> On Thu, May 4, 2023 at 8:37 AM vignesh C <vignesh21@gmail.com> wrote:
>>>>
>>>> Thanks for posting the updated patch, I had run this test in a loop of
>>>> 100 times to verify that there was no failure because of race
>>>> conditions. The 100 times execution passed successfully.
>>>>
>>>> One suggestion:
>>>> "wal file" should be changed to "WAL file":
>>>> +# Request a checkpoint on the standby to trigger the WAL file(s) removal
>>>> +$node_standby->safe_psql('postgres', 'checkpoint;');
>>>> +
>>>> +# Verify that the wal file has not been retained on the standby
>>>> +my $standby_walfile = $node_standby->data_dir . '/pg_wal/' . $walfile_name;
>>>>
>>>
>>> Thanks for the verification. I have pushed the patch.
>>>
>>
>> It looks like there is still something wrong with this test as there
>> are a bunch of cfbot errors on this new test (mainly on macOS - Ventura - Meson).
>>
> 
> Is it possible for you to point me to those failures?
> 
>> I'll try to reproduce with more debug infos.
>>
> 
> Okay, thanks!
> 

After multiple attempts, I got one failing one.

Issue is that we expect this file to be removed:

[07:24:27.261](0.899s) #WAL file is /Users/admin/pgsql/build/testrun/recovery/035_standby_logical_decoding/data/t_035_standby_logical_decoding_standby_data/pgdata/pg_wal/000000010000000000000003

But the standby emits:

2023-05-05 07:24:27.216 UTC [17909][client backend] [035_standby_logical_decoding.pl][3/6:0] LOG:  statement: checkpoint;
2023-05-05 07:24:27.216 UTC [17745][checkpointer] LOG:  restartpoint starting: immediate wait
2023-05-05 07:24:27.259 UTC [17745][checkpointer] LOG:  attempting to remove WAL segments older than log file 000000000000000000000002

So it seems the test is not right (missing activity??), not sure why yet.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com