Feedback-ID: ie0a040ee:Fastmail
Message-ID: <a41f2853-ebb5-4d7d-9e4a-eccafec7470d@eisentraut.org>
Date: Tue, 12 Nov 2024 17:07:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Virtual generated columns
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 jian he <jian.universality@gmail.com>
References: <a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org>
 <CACJufxE+E-iYmBnZVZHiYA+WpyZZVv7BfiBLpo=T70EZHDU9rw@mail.gmail.com>
 <fd6d260b-a401-4355-8688-e3bcb7e93527@eisentraut.org>
 <CACJufxGh=XX7q5xTci---HikSJsOwP7_qCNyyDHdp2YL4NLZCg@mail.gmail.com>
 <CACJufxHxoz_KVQxcQ=cSvJc+PNbh=FaHbcMZCOisoOaGAgjy4w@mail.gmail.com>
 <732a9543-0312-4f0c-a471-857b507a3546@eisentraut.org>
 <ebd1e0e9-115f-4dfa-98b8-e9b8e2f9eb2d@eisentraut.org>
 <CAEZATCV=RX0M58-uqSR6tFjwQAFnEcx3hvW-9ZZfRQJLg5LzRw@mail.gmail.com>
 <0f811f71-8c86-4e1b-b3bb-6a535674a440@eisentraut.org>
 <CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
 <cd7c0fea-6c4b-4bdd-af3b-4d4dabb32ca1@eisentraut.org>
 <CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
 <ef7c466d-e3b9-4d60-bc03-cd9b48581442@eisentraut.org>
 <09800cb1-43aa-4239-8918-46b71ede4900@eisentraut.org>
 <536b281b-2cb3-4477-971f-c64838bc6263@eisentraut.org>
 <CAEZATCXT6VO8Q3NBYMHr3YhiRzF=kmgvj41xU3qQOiNmzF7jTQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAEZATCXT6VO8Q3NBYMHr3YhiRzF=kmgvj41xU3qQOiNmzF7jTQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a41f2853-ebb5-4d7d-9e4a-eccafec7470d%40eisentraut.org>
Precedence: bulk

On 07.11.24 11:02, Dean Rasheed wrote:
> On Tue, 5 Nov 2024 at 16:17, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> New patch version.
> 
> In expand_generated_columns_in_expr():
> 
> +        /*
> +         * XXX For the benefit of triggers, make two passes, so it covers
> +         * PRS2_OLD_VARNO and PRS2_NEW_VARNO.
> +         */
> +        node = expand_generated_columns_internal(node, rel, 1, rte);
> +        node = expand_generated_columns_internal(node, rel, 2, rte);
> 
> It seems a bit messy to be doing these two passes in
> expand_generated_columns_in_expr(), when it is only needed for
> triggers. I think it was better the way it was in the v7 patch,
> passing rt_index to expand_generated_columns_in_expr(), so that
> TriggerEnabled() did this:
> 
> +            tgqual = (Node *)
> expand_generated_columns_in_expr(tgqual, relinfo->ri_RelationDesc,
> PRS2_OLD_VARNO);
> +            tgqual = (Node *)
> expand_generated_columns_in_expr(tgqual, relinfo->ri_RelationDesc,
> PRS2_NEW_VARNO);

Yeah, I put it back that way in v9.