Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ux46e-00AOHU-AX for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Sep 2025 13:46:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ux46a-001JgP-UN for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Sep 2025 13:46:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ux46a-001JgE-Kr for pgsql-hackers@lists.postgresql.org; Fri, 12 Sep 2025 13:46:25 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ux46X-000QFY-1M for pgsql-hackers@lists.postgresql.org; Fri, 12 Sep 2025 13:46:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1757684780; bh=32RFbJS0rP/27NILbNS5wVTQPgzk0QJqpUJRrXKDS9Q=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:User-Agent: From; b=aTtECG68+UR2ZlKQDCUftyhtCKfaooGghN2RHSOs7HAJM5LoLkf/h5lQSdcAjjP9P KUZPdINPxFLAZtXmaPTuOpic3HF/gZyywNtmAbC1dW9In99i/qBAfIssAzkT9XzueI YZSjTiNJ7f+MGSWLOtIqsORLwsmViTwHggDwsl9p/Ay6G9kf2+1XeEmNTaL5ZPxJXz UEa37rmYlNlbnG2JH6s+ZNaGdJgk50mIfM67BSxYFcAI5lKH58hOGvv2lyXUPT1MFb cjthheJtold5WPlVPC4SuReE1brfPpJPYyMkwFgBW3gH2OJm0uaI2323q3810EEzI9 bIt4IfpFzO2PQ== Received: from [10.9.2.28] (unknown [31.187.97.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: t.magomedov@postgrespro.ru) by mail.postgrespro.ru (Postfix/465) with ESMTPSA id 3A25D6083E; Fri, 12 Sep 2025 16:46:20 +0300 (MSK) Message-ID: Subject: Re: [PATCH] ternary reloption type From: Timur Magomedov To: Nikolay Shaplov , PostgreSQL Hackers , =?ISO-8859-1?Q?=C1lvaro?= Herrera , Chris Travers Date: Fri, 12 Sep 2025 16:46:19 +0300 In-Reply-To: <11330814.CDJkKcVGEf@thinkpad-pgpro> References: <3474141.usfYGdeWWP@thinkpad-pgpro> <11330814.CDJkKcVGEf@thinkpad-pgpro> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1 MIME-Version: 1.0 X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/09/12 11:55:00 #27811856 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Nikolay! Found a typo in reloptions.h, treaed -> treated. Can ternary enum be added in a separate header file, say, src/include/ternary.h instead of adding it to c.h? I'm just not sure if c.h is it the right place for relation-options-specific code. Of course, I can be wrong. --=20 Regards, Timur Magomedov