Subject: Re: Add a description to the documentation that toast_tuple_target
 affects "Main"
To: Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>,
 Shinya Okano <btokanosn@oss.nttdata.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <93f46e311a67422e89e770d236059817@oss.nttdata.com>
 <CAP0=ZVJ9Wh2RnphL4nB6PuhODCxeMBBkzg3=5oSu+1FMOaNK6Q@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <a4941ace-b898-3bd4-270f-2ccc1dc2af07@oss.nttdata.com>
Date: Wed, 14 Oct 2020 01:30:06 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: 
 <CAP0=ZVJ9Wh2RnphL4nB6PuhODCxeMBBkzg3=5oSu+1FMOaNK6Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
> Hi,
> 
> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>
>> Hi,
>>
>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>> documentation says that it only affects External or Extended, but it
>> actually affects the compression of Main as well.
>>
>> The attached patch modifies the document to match the actual behavior.
> +1

+1

+      we try to compress long column values or to move into TOAST tables, and

"we try to compress and/or move long column values into TOAST tables, and" is better?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION