public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jeff Davis <[email protected]>
To: Julien Rouhaud <[email protected]>
Cc: [email protected]
Cc: Andres Freund <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Simon Riggs <[email protected]>
Subject: Re: Extensible Rmgr for Table AMs
Date: Tue, 01 Feb 2022 15:38:32 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <20220201124550.gnhpw7iytc4da5tq@jrouhaud>
References: <[email protected]>
	<[email protected]>
	<20220118095332.6xtlcjoyxobv6cbk@jrouhaud>
	<[email protected]>
	<20220201043938.r5s35loehsi27saj@jrouhaud>
	<20220201124550.gnhpw7iytc4da5tq@jrouhaud>

On Tue, 2022-02-01 at 20:45 +0800, Julien Rouhaud wrote:
> On Tue, Feb 01, 2022 at 12:39:38PM +0800, Julien Rouhaud wrote:
> > 
> > Other than that the patch looks good to me, as you said we just
> > need a decision
> > on whether custom rmgrs are wanted or not.
> 
> One last thing, did you do some benchmark with a couple custom rmgr
> to see how
> much the O(n) access is showing up in profiles?

What kind of a test case would be reasonable there? You mean having a
lot of custom rmgrs?

I was expecting that few people would have more than one custom rmgr
loaded anyway, so a sparse array or hashtable seemed wasteful. If
custom rmgrs become popular we probably need to have a larger ID space
anyway, but it seems like overengineering to do so now.

Regards,
	Jeff Davis

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Extensible Rmgr for Table AMs
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox