Subject: Re: PATCH: two slab-like memory allocators
To: Andres Freund <andres@anarazel.de>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>
References: <b8ded0aa-2515-7ffd-162b-8f515df5eca1@2ndquadrant.com>
 <CA+Tgmob7u4thiBbdvyseQk1aVApJeG10C_rFFt8LPV03-UzD7g@mail.gmail.com>
 <a4593432-c989-8ec4-2320-943e3f97ce6d@2ndquadrant.com>
 <CA+TgmobJrM74FRTcmn2JDMVbLB0a5pj5e3ieLBMzkDNtrxF4dw@mail.gmail.com>
 <9818b54a-fcb6-f018-0b16-96d6a1d1da27@2ndquadrant.com>
 <34a6d4ea-7f3d-a62c-fff1-7a9108c078d7@2ndquadrant.com>
 <f2aaf4a5-412c-a4b9-389d-c9f682fbdc77@2ndquadrant.com>
 <4f176a6c-c197-165d-dee4-5de8f279f1f4@2ndquadrant.com>
 <20161112191257.3a4n6kzegvu637qn@alap3.anarazel.de>
 <efd47210-cf95-d7ee-e984-a873f76596a8@2ndquadrant.com>
 <20161127204740.dr3swudwsbafjuof@alap3.anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, John Gorman <johngorman2@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Petr Jelinek <petr@2ndquadrant.com>
Message-ID: <a4b35a6e-7b8a-1550-1543-e5e77183ab5f@2ndquadrant.com>
Date: Sun, 27 Nov 2016 22:21:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161127204740.dr3swudwsbafjuof@alap3.anarazel.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 27/11/16 21:47, Andres Freund wrote:
> Hi,
> 
>>> +typedef struct SlabBlockData *SlabBlock;		/* forward reference */
>>> +typedef struct SlabChunkData *SlabChunk;
>>>
>>> Can we please not continue hiding pointers behind typedefs? It's a bad
>>> pattern, and that it's fairly widely used isn't a good excuse to
>>> introduce further usages of it.
>>>
>>
>> Why is it a bad pattern?
> 
> It hides what is passed by reference, and what by value, and it makes it
> a guessing game whether you need -> or . since you don't know whether
> it's a pointer or the actual object. All to save a * in parameter and
> variable declaration?...
> 

FWIW I don't like that pattern either although it's used in many parts
of our code-base.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers