Message-ID: <a4c7fd7a-4bcd-a783-9055-2d85d8299217@highgo.ca>
Date: Tue, 19 Apr 2022 12:54:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: postgres_fdw: commit remote (sub)transactions in parallel during
 pre-commit
Content-Language: en-US
To: Etsuro Fujita <etsuro.fujita@gmail.com>,
 Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAPmGK17dAZCXvwnfpr1eTfknTGdt=hYTV9405Gt5SqPOX8K84w@mail.gmail.com>
 <CAPmGK15FuPVGx3TGHKShsbPKKtF1y58-ZLcKoxfN-nqLj1dZ=g@mail.gmail.com>
 <d888307d-c5b2-88e7-e2c0-f2228ad0756b@oss.nttdata.com>
 <CAPmGK158hrd=ZfXmgkmNFHivgh18e4oE2Gz151C2Q4OBDjZ08A@mail.gmail.com>
 <3e57ebd7-b536-333e-c877-49a3ebb57079@oss.nttdata.com>
 <CAPmGK17nfEZkKhqoP8fAPKbnfSpf2JVgV5+_Xjv2mn8P-4X0hQ@mail.gmail.com>
 <2a2519b5-0c1f-87c8-5461-a4d8be0728e0@oss.nttdata.com>
 <CAPmGK152dsQHAzZC-g55M08Z-ur-h8m4J7FD0L3eh5uazCmvAQ@mail.gmail.com>
 <883589bb-077f-7d66-2406-5f67be0372a6@oss.nttdata.com>
 <CAPmGK16sRsm30a_1dpWPkVoTANg=F3H1vLRLyek-Xcw_r7JPkQ@mail.gmail.com>
 <CAPmGK15GPmCo7xBFKsi9zZnsRV-xbi8axFSRdFUzwpGBfu9NDg@mail.gmail.com>
 <CAPmGK15mbbsEEEULK9XTAy4c78JnCfhtZ_AnPUyjjGXSe-sbGA@mail.gmail.com>
 <CAPmGK15SkX=1NrY+GVyZan4Za+f17FFnM9qtQvjCEMaE3ftPcg@mail.gmail.com>
 <CAPmGK16ABpu+ff1Wiwj3MztbDi2qFNmFEa_andc3LmVbCvADCw@mail.gmail.com>
 <CAPmGK16RWyc1nJsFnsn7-=UFzQiq4OGm70PK4-=5Y2fH_Gr4iA@mail.gmail.com>
From: David Zhang <david.zhang@highgo.ca>
In-Reply-To: <CAPmGK16RWyc1nJsFnsn7-=UFzQiq4OGm70PK4-=5Y2fH_Gr4iA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/a4c7fd7a-4bcd-a783-9055-2d85d8299217%40highgo.ca>
Precedence: bulk

I tried to apply the patch to master and plan to run some tests, but got 
below errors due to other commits.

$ git apply --check 
v7-0003-postgres-fdw-Add-support-for-parallel-abort.patch
error: patch failed: doc/src/sgml/postgres-fdw.sgml:479
error: doc/src/sgml/postgres-fdw.sgml: patch does not apply


+     * remote server in parallel at (sub)transaction end.

Here, I think the comment above could potentially apply to multiple 
remote server(s).


Not sure if there is a way to avoid repeated comments? For example, the 
same comment below appears in two places (line 231 and line 296).

+    /*
+     * If requested, consume whatever data is available from the socket.
+     * (Note that if all data is available, this allows
+     * pgfdw_get_cleanup_result to call PQgetResult without forcing the
+     * overhead of WaitLatchOrSocket, which would be large compared to the
+     * overhead of PQconsumeInput.)
+     */

On 2022-03-24 11:46 p.m., Etsuro Fujita wrote:
> On Thu, Mar 24, 2022 at 1:34 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>> Attached is a new patch set.  The new version of 0002 is just a
>> cleanup patch (see the commit message in 0002), and I think it's
>> committable, so I'm planning to commit it, if no objections.
> Done.
>
> Attached is the 0003 patch, which is the same as the one I sent yesterday.
>
> Best regards,
> Etsuro Fujita
-- 
Best regards,
David

Software Engineer
Highgo Software Inc. (Canada)
www.highgo.ca