Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qt0ri-00ATfV-Re for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Oct 2023 07:21:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qt0rg-000rx4-KC for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Oct 2023 07:21:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qt0rf-000rwv-KB for pgsql-hackers@lists.postgresql.org; Wed, 18 Oct 2023 07:21:13 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qt0rX-001Jvj-FN for pgsql-hackers@postgresql.org; Wed, 18 Oct 2023 07:21:11 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 873A83200A47; Wed, 18 Oct 2023 03:21:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 18 Oct 2023 03:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm2; t=1697613660; x=1697700060; bh=HmovSgSYeBzr6OjsZITwhboRL AQZctCjjCP5U/aBHkc=; b=OzTW4j+GON2AH2UtZ0aCoz2A2+/iSlJ0mlH0UEB/l bz3/X6upM7ZwRTfh4L4/D6nUYgoKmwrjI+VYfj9NPU2HiDlxl669q9t1EBEVCnUm pCzHFObvOauVRL3m7IKIW9jn7ZHIjSPk4OKUTAM0orTJ7cPkIC2VDPneLudH0Dkz FP9kc7WFU7XdXD/cWlbFf0oy3acO4kDtPoflslEgx8eXw+Jkmg1fujAklADEAsim OoHDV4wh9Ojy+x/nnR/moElI+jMqh6+7nOX6PRp4NeKvIG9SQ1tkQxLfrfKxq4mP LQG8+qIHxHFLV9jr1BddOolkRTArJsReIxgw6rSeyeF/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697613660; x=1697700060; bh=HmovSgSYeBzr6OjsZITwhboRLAQZctCjjCP 5U/aBHkc=; b=t/p5VzmrxcYXFW/OlTCS9x3nWNlP/SflFAPsidtGssZDzpP3AKk 1wLglP5UsAR/8ciPBXQrHRdo7w7YhuH+nrHLMd+QJiWmsyCaXKJQH44/U2C6OOrj R4HPyVCrt9jdMb1wD8Im9j+IsjI1Xx3CC+X1EakbBefx3IiK1Zuq7fWpAA/1I6w1 dx+mIu5nR+D+pHHMPyPAnL94cvvGQ3AROlDbGhc6JqYw7Ox7POhWLWPYTGHkKkr1 Gs3lnCldv6TWPebRCnQiBF5uMW+Og9FnRCKgIEDDN6ceDdZ8NUH21cEh7vwsph6c xIMCmwPeRYeu6LEdWIsHgGe7IozXIK8rqCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeefgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileehteeljeeghfeuledthfeu tedvffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Oct 2023 03:20:56 -0400 (EDT) Message-ID: Date: Wed, 18 Oct 2023 09:20:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US To: David Rowley , Robert Haas Cc: Peter Geoghegan , Tom Lane , Andres Freund , Andrew Dunstan , Jelte Fennema , Michael Paquier , "shiy.fnst@fujitsu.com" , Justin Pryzby , Noah Misch , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut References: <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de> <338202.1691793002@sss.pgh.pa.us> <342032.1691794926@sss.pgh.pa.us> <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net> <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de> <530189.1691880417@sss.pgh.pa.us> <544112.1691886017@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 18.10.23 06:40, David Rowley wrote: > I agree that it's not nice to add yet another way of breaking the > buildfarm and even more so when the committer did make check-world > before committing. We have --enable-tap-tests, we could have > --enable-indent-checks and have pgindent check the code is correctly > indented during make check-world. Then just not have > --enable-indent-checks in CI. This approach seems like a good improvement, even independent of everything else we might do about this. Making it easier to use and less likely to be forgotten. Also, this way, non-committer contributors can opt-in, if they want to earn bonus points.