public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tomas Vondra <[email protected]>
To: Arseniy Mukhin <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: amcheck support for BRIN indexes
Date: Mon, 7 Jul 2025 14:10:07 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAE7r3MKr7oGnT5o8jEa91PEBZwo-bWg0d6P1N-Xx9AqQ_KjL5A@mail.gmail.com>
References: <CAE7r3MJFTso-uT2dTGg5rdvEHgyQQAu7YFR5sDUZLAtnC2ThCw@mail.gmail.com>
	<[email protected]>
	<CAE7r3MKr7oGnT5o8jEa91PEBZwo-bWg0d6P1N-Xx9AqQ_KjL5A@mail.gmail.com>



On 7/7/25 13:06, Arseniy Mukhin wrote:
> On Sun, Jul 6, 2025 at 10:49 PM Álvaro Herrera <[email protected]> wrote:
>>
>> On 2025-Jul-06, Arseniy Mukhin wrote:
>>
>>> Sorry, forget to run a full test run with the new patch version. Some
>>> tests were unhappy with the new unknown support function. Here the new
>>> version with the fix.
>>
>> Hello, I think this patch is probably a good idea.  I don't think it
>> makes sense to introduce a bunch of code in 0003 only to rewrite it
>> completely in 0005.  I would ask that you re-split your WITHIN_RANGE
>> (0004) to appear before the amcheck code, and then write the amcheck
>> code using that new functionality.
> 
> Hi, Álvaro!
> 
> Thank you for looking into this.
> 
> OK, we can easily revert to the version with consistent function if
> needed, so let's get rid of it.
> 

Alvaro, what's your opinion on the introduction of the new WITHIN_RANGE?
I'd probably try to do this using the regular consistent function:

(a) we don't need to add stuff to all BRIN opclasses to support this

(b) it gives us additional testing of the consistent function

(c) building a scan key for equality seems pretty trivial

What do you think?


-- 
Tomas Vondra

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: amcheck support for BRIN indexes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox