MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 15 Jan 2018 15:07:01 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Alvaro
 Herrera <alvherre@alvh.no-ip.org>
Subject: Re: master make check fails on Solaris 10
Organization: Postgres Professional
In-Reply-To: <15299.1515867055@sss.pgh.pa.us>
References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru>
 <20180111173938.jimybeayp2u5mmup@alap3.anarazel.de>
 <31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru>
 <fc3c1b52d2d4121cccfc13635005bbd0@postgrespro.ru>
 <1232.1515780057@sss.pgh.pa.us>
 <b946893927ccfd87146d8a7c9f3bbe29@postgrespro.ru>
 <15299.1515867055@sss.pgh.pa.us>
Message-ID: <a5559105243efcf6fb619d86c5702115@postgrespro.ru>
User-Agent: Roundcube Webmail/1.2.4
Precedence: bulk

Thank you very much!

On 13-01-2018 21:10, Tom Lane wrote:
> Marina Polyakova <m.polyakova@postgrespro.ru> writes:
>> On 12-01-2018 21:00, Tom Lane wrote:
>>> Hm ... so apparently, that compiler has bugs in handling nondefault
>>> alignment specs.  You said upthread it was gcc, but what version
>>> exactly?
> 
>> This is 5.2.0:
> 
> Ugh ... protosciurus has 3.4.3, but I see that configure detects that
> as *not* having __int128.  Probably what's happening on your machine
> is that gcc knows __int128 but generates buggy code for it when an
> alignment spec is given.  So that's unfortunate, but it's not really
> a regression from 3.4.3.
> 
> I'm not sure there's much we can do about this.  Dropping the use
> of the alignment spec isn't a workable option.  If there were a
> simple way for configure to detect that the compiler generates bad
> code for that, we could have it do so and reject use of __int128,
> but it'd be up to you to come up with a workable test.

I'll think about it..

> In the end this might just be an instance of the old saw about
> avoiding dot-zero releases.  Have you tried a newer gcc?
> (Digging in their bugzilla finds quite a number of __int128 bugs
> fixed in 5.4.x, though none look to be specifically about
> misaligned data.)

As I was told offlist, 5.2.0 is already a fairly new version of gcc for 
this system..

> Also, if it still happens with current gcc on that hardware,
> there'd be grounds for a new bug report to them.

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company