Subject: Re: jit and explain nontext
To: Justin Pryzby <pryzby@telsasoft.com>, David Rowley <dgrowleyml@gmail.com>
References: <20201014193859.GS9241@telsasoft.com>
 <CAApHDvpPt=iN=f5gHQSCA073mp5KO46gsEZFgTWc4xbzKshb9g@mail.gmail.com>
 <3643530.1602724513@sss.pgh.pa.us>
 <CAApHDvqK2HAm-BWxgo7=7GG5xERuECwgny+Sxh3iLfXmhR_yBQ@mail.gmail.com>
 <20201015014326.GU9241@telsasoft.com>
 <CAApHDvozf41o7bUyLL42LWwAjqjRuDToeWy-S5jwR4BieM7SYA@mail.gmail.com>
 <20201017192134.GD9241@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org,
 Andres Freund <andres@anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Organization: EnterpriseDB
Message-ID: <a56f853c-e671-c4b1-7e0e-a1f0a18621e4@enterprisedb.com>
Date: Fri, 20 Nov 2020 16:56:38 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20201017192134.GD9241@telsasoft.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-10-17 21:21, Justin Pryzby wrote:
> Added at:https://commitfest.postgresql.org/30/2766/
> 
> diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
> index 41317f1837..7345971507 100644
> --- a/src/backend/commands/explain.c
> +++ b/src/backend/commands/explain.c
> @@ -839,7 +839,8 @@ ExplainPrintJIT(ExplainState *es, int jit_flags, JitInstrumentation *ji)
>   	instr_time	total_time;
>   
>   	/* don't print information if no JITing happened */
> -	if (!ji || ji->created_functions == 0)
> +	if (!ji || (ji->created_functions == 0 &&
> +			es->format == EXPLAIN_FORMAT_TEXT))
>   		return;
>   
>   	/* calculate total time */

Can you show an output example of where this patch makes a difference? 
Just from reading the description, I would expect some kind of 
additional JIT-related output from something like

EXPLAIN (FORMAT YAML) SELECT 1;

but I don't see anything.