Message-ID: <a5831ccc-6bce-feba-6910-338dabf85be1@linaro.org>
Date: Fri, 2 Dec 2022 09:50:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.0
Subject: Re: [PATCH] Add native windows on arm64 support
Content-Language: en-US
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andres Freund
 <andres@anarazel.de>, Ian Lawrence Barwick <barwick@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>,
 Julien Rouhaud <rjuju123@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <Yw6oBJgXWnJsy3SE@paquier.xyz> <3886822.1661905738@sss.pgh.pa.us>
 <Yw77DNnYl1qkaW1S@paquier.xyz> <20476.1661967233@sss.pgh.pa.us>
 <Yw/9pgS35urJZu/7@paquier.xyz> <271611.1661998926@sss.pgh.pa.us>
 <YxA4F7EB3SBenvva@paquier.xyz>
 <CAB8KJ=jEZZa=2sgtpjq4raTaqh3vxx5GFFKWF=OZFHo6vp0cGg@mail.gmail.com>
 <CAFPTBD8CCT9BNdQQ0QELoo7HPqx26_Zkn0jxg9F9u+bPz-jnEg@mail.gmail.com>
 <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
 <Y2ishWF0ZkD2JIpv@paquier.xyz>
 <7ff7c416-fdfe-517f-a65c-9e5bd8ff8cec@linaro.org>
 <CAFBsxsHxD0bjjN05sxKLoz8H7oso2-PAKdUhxhTPQCejTiyWHw@mail.gmail.com>
From: Niyas Sait <niyas.sait@linaro.org>
In-Reply-To: 
 <CAFBsxsHxD0bjjN05sxKLoz8H7oso2-PAKdUhxhTPQCejTiyWHw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a5831ccc-6bce-feba-6910-338dabf85be1%40linaro.org>
Precedence: bulk

On 02/12/2022 05:41, John Naylor wrote:
>> I couldn't find something more official for the sse2neon library part.
> Not quite sure what this is referring to, but it seems we can just point to
> the __aarch64__ section in the same file, which uses the same instruction:
> 
> spin_delay(void)
> {
>    __asm__ __volatile__(
>    " isb; \n");
> }
> 
> ...and which already explains the choice with a comment.

Good point. Will add the comment.

> +  if cc.get_id() == 'msvc'
> +    cdata.set('USE_ARMV8_CRC32C', false)
> +    cdata.set('USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK', 1)
> +    have_optimized_crc = true
> +  else
> 
> That seems like a heavy-handed way to force it. Could we just use the same
> gating in the test program that the patch puts in the code of interest?
> Namely:
> 
> +#ifndef _MSC_VER
>  #include <arm_acle.h>
> +#endif
I took a similar approach as x86 MSVC code. I don't think the test 
program would work with MSVC. The compiler options are not MSVC friendly.

-- 
Niyas