Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTbVV-005hcX-2u for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Dec 2025 07:54:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vTbVU-002skY-2b for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Dec 2025 07:54:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTbVU-002skP-1f for pgsql-hackers@lists.postgresql.org; Thu, 11 Dec 2025 07:54:37 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vTbVT-0006jW-2G for pgsql-hackers@postgresql.org; Thu, 11 Dec 2025 07:54:36 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4775895d69cso2453255e9.0 for ; Wed, 10 Dec 2025 23:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765439674; x=1766044474; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9nYxrzWqlrUSme70uDAacJKr2XjuMWQQR5sSejR0lTY=; b=LUOkSCCB2H+pwCDhTM7ctCSn0UrXCCkE/q/5u1q6cMzvZeTB99c2NaxcRAz2Ga9XB4 5wxxN/1QrxxNZ50IavVzncGdNQfsw0infLz0Gd+0Zyqm0wJUSsR5VI9W/uHkHQSlofPB b8NeKe7xm6kPM9rKvmyXcdPceuRJHx0gIwNEkt4qqJJyj0N8MxaUrNFCFp6GB48uF5CJ IXj24ioXF2mmekTjwaXzKVHPvBkmf5lDDrJHcomcWuL3FUIB6anSmNwtmGxHfIyBnUKN lFTzunpXwWBsd1IWHYt9GR23OmLcf0R+Pr/qT5JAzCWD4d/nz+5ZoLCQ66MAawCVUSDi V7UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765439674; x=1766044474; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9nYxrzWqlrUSme70uDAacJKr2XjuMWQQR5sSejR0lTY=; b=UlQcd3MI9eBU+b9JWtyrbJ1Tvyfjwr6D6veftMO6W4IZ3a0MUnJcz4TBytPQfAE5ra eDviaUv+iK7CtEqcX3uuc0899hul9o3f7IfYXCgDOjPXLc5NdYVDvTiGA/aCs5vWcaoP ago2WdPUcjpZZAT7SnjWw7NxoQnD7WFfwtXCLOY3quz5pYEvRPHkCZGU4EQiEIg+GEjp 4lcrSOgJ2YgP6lhsjzdn8YC7ppRVosiAxrscDh3JkrKRhJTuhBR/0gm/UBYGJhwCSYDS hTM/XNYBtdjYuGmKoA+0aA7R81//bJYgsYC3Nvi5KEGSygMuzw5301dIIM8UYBBHlvDC nr1A== X-Forwarded-Encrypted: i=1; AJvYcCWR8ad3Q0kiV9sxJxoOL/JaPQ2Fw0lYxCdlY4DfsoGYHcyrLEmRjr8JOx1qkbOcKfFlSFwFssWpt56/QJw4@postgresql.org X-Gm-Message-State: AOJu0YwbXgZqQWc/ASmhh23w8L5f6J4rwDjNudoBPpy2f0wp4Ec0JdCx n+OuZiRJ4nDIiyrM0NfOMrTX/duvboWYhhtVpVi3xaoOfb+Q3AfSOqOP X-Gm-Gg: AY/fxX5Jpor1kpflUDEJkORWPv4tfbg/cDQ+4uPSQ2UXJ658O8rjJkJz8tlPuZOC0WP GIKdx6TorVvEgqUUEKPSgB7blXaHGudxswvpKaKpji6mEabJoUQa/yJ4OlMwrRUjU/Pon/3A4gU mnX8GIlWoOCYLO8OfCrm06HwKhWPtQR7DzoaDglYx23eOHaUAR47uOKocubJJUtvCNCxrQ+iwr5 sa31x4Wkq1YEO770chA8Cohq0SZWVqzzmo3QLmS2Bt7XughDNaihdc/oNkHRNt5rHrVF7YzIBxj 8mMVyyYwKARlquxblkkX2rAcjE7hF+Q53/ocy4ZeUsFL2VeMqeIRTpEOdCioZy4hrJ/q7W2t5DT gSpzUNVatZLirAlCX9NjZ422Mdx5M0BnE4NDw4JUfJjv3H4sOojG+7P1cl7CpDyOasBhINbcCWD WVtDblg3qkdL5W0MpbzqQMZ/Bx+Q== X-Google-Smtp-Source: AGHT+IFN5cXgJGskhoX/HshZdQLb0fVD24SIQ8nrNRM8nFzE9e/NovWvcLT9UTWPDwcqNuGsMriGQg== X-Received: by 2002:a05:600c:1c93:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47a837b9a4cmr53640675e9.26.1765439673668; Wed, 10 Dec 2025 23:54:33 -0800 (PST) Received: from [192.168.2.32] ([165.225.27.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a89f0eabcsm19413325e9.15.2025.12.10.23.54.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 23:54:33 -0800 (PST) Message-ID: Date: Thu, 11 Dec 2025 08:54:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Consistently use palloc_object() and palloc_array() To: Tom Lane Cc: Michael Paquier , Thomas Munro , Chao Li , pgsql-hackers References: <524587.1764365323@sss.pgh.pa.us> <1e7f0c17-a965-4d5b-ad88-b435a4d97490@gmail.com> <143d3184-b575-49bd-8bc1-f37f45f010cc@gmail.com> <534126.1764722446@sss.pgh.pa.us> <4ab4a12b-49e9-4ebf-9055-225c8055fed0@gmail.com> <1433178.1764946037@sss.pgh.pa.us> Content-Language: en-US From: David Geier In-Reply-To: <1433178.1764946037@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 05.12.2025 15:47, Tom Lane wrote: > David Geier writes: >> My bad. I hadn't realized that - obviously - not necessarily all code is >> actually compiled by default. > >> Will the build system enable any target for which all dependencies (e.g. >> libraries) are met, or are there targets that need to be enabled >> explicitly? Is there a way to enable all of them so I can easily make >> sure, I actually compile all code? > > There's a good deal of platform-specific code in PG, particularly for > Windows, and obviously none of that will be built unless you're on the > right platform. (You can reach some of the Windows-specific code on > other systems with -DEXEC_BACKEND, but that goes only so far.) > > As for optional-feature stuff, I think the meson build system will by > default build every option it can find the supporting libraries for. > But the other side of that coin is that if you didn't install the > right packages it will silently not build it. > > I think the most reliable way is to look at "./configure --help" > and select all the options you think should work on your platform. > Then, if you forgot to install libfoo-devel or whatever, you'll > get configure failures. Thanks for the pointers. Do we know what code each build animal actually has enabled? The platform specific code is clear but anything that depends on specific libraries being installed is not. Do build animal owners try to enable as much code as possible, or is this completely up to what the owner happened to do when setting up the build animal? I'm wondering how much more code coverage we could get on each animal if maximized the amount of code that is enabled. -- David Geier