Message-ID: <a5cf0a2f-a97f-e350-35bf-d7df5e51e093@gmail.com>
Date: Thu, 6 Jun 2024 22:00:01 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Assert in heapgettup_pagemode() fails due to underlying buffer
 change
Content-Language: en-US
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <7ed10231-ce47-03d5-d3f9-4aea0dc7d5a4@gmail.com>
 <CA+TgmoYbxzL4Zexu6cAZSrjYNRKVn+7t6Pccn+TaVry3sefT+w@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <CA+TgmoYbxzL4Zexu6cAZSrjYNRKVn+7t6Pccn+TaVry3sefT+w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/a5cf0a2f-a97f-e350-35bf-d7df5e51e093%40gmail.com>
Precedence: bulk

Hello Robert,

06.06.2024 19:36, Robert Haas wrote:
> On Thu, Jun 6, 2024 at 6:00 AM Alexander Lakhin <exclusion@gmail.com> wrote:
>> Am I missing something or the the page buffer indeed lacks locking there?
> I don't know, but if the locks are really missing now, I feel like the
> first question is "which commit got rid of them?". It's a little hard
> to believe that they've never been there and somehow nobody has
> noticed.
>
> Then again, maybe we have; see Noah's thread about in-place updates
> breaking stuff and some of the surprising discoveries there. But it
> seems worth investigating.

Yes, my last experiment with memcmp for the whole buffer was wrong,
given the comment above heapgettup_pagemode(). I think the correct
check would be:
              ItemId      lpp;
              OffsetNumber lineoff;
+ItemIdData      iid;

              lineoff = scan->rs_vistuples[lineindex];
              lpp = PageGetItemId(page, lineoff);
+iid = *((ItemIdData *)lpp);
+for (int i = 0; i < 1000; i++)
+Assert(memcmp(&iid, lpp, sizeof(iid)) == 0);

It significantly alleviates reproducing of the test failure for me.
Will try to bisect this anomaly tomorrow.

Best regards,
Alexander