Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qXwgn-000OR5-LQ
	for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Aug 2023 04:38:53 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qXwgm-002Npe-4y
	for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Aug 2023 04:38:51 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ikedamsh@oss.nttdata.com>)
	id 1qXwgl-002NpW-Ql
	for pgsql-hackers@lists.postgresql.org; Mon, 21 Aug 2023 04:38:51 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ikedamsh@oss.nttdata.com>)
	id 1qXwgi-0006cv-Uv
	for pgsql-hackers@lists.postgresql.org; Mon, 21 Aug 2023 04:38:51 +0000
Received: from oss.nttdata.com (localhost [127.0.0.1])
	by oss.nttdata.com (Postfix) with ESMTPA id B034F6099C;
	Mon, 21 Aug 2023 13:38:45 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 21 Aug 2023 13:38:45 +0900
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Masahiko Sawada
 <sawada.mshk@gmail.com>, Andres Freund <andres@anarazel.de>,
 pgsql-hackers@lists.postgresql.org, mitsuru.hinata.5432@gmail.com
Subject: Re: Fix pg_stat_reset_single_table_counters function
In-Reply-To: <ZOLpUtMeq8rg8JWk@paquier.xyz>
References: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com>
 <9a4a6718abb47647ae83f1f4b3f9bf68@oss.nttdata.com>
 <CAD21AoCnFqzzW7DUW67Art=2w_Z3gwKU1suSn0d0UtUPtdbt_g@mail.gmail.com>
 <20230812191207.aerskqox7aoan3ud@awork3.anarazel.de>
 <97c9f7a46681f051b1356e2987c3fd6c@oss.nttdata.com>
 <CAD21AoDhhdicG3rYwKq3fLngn=T4qRuFiOWtqeYFwMM_-R43WQ@mail.gmail.com>
 <93d14a670cf090c08994f1f4958efa25@oss.nttdata.com>
 <0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com>
 <ZOLpUtMeq8rg8JWk@paquier.xyz>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <a66ff7ca6f4349f8629a35379c5937ca@oss.nttdata.com>
X-Sender: ikedamsh@oss.nttdata.com
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/a66ff7ca6f4349f8629a35379c5937ca%40oss.nttdata.com>
Precedence: bulk

On 2023-08-21 13:34, Michael Paquier wrote:
> On Mon, Aug 21, 2023 at 11:33:28AM +0900, Kyotaro Horiguchi wrote:
>> I'm not sure about others, but I would avoid using the name
>> "current_database" for the variable.
> 
> Agreed.  Looking at the surroundings, we have for example "datname" in
> the collation tests so I have just used that, and applied the patch
> down to 15.

Thanks!

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION