Feedback-ID: i131946ab:Fastmail
Message-ID: <a6a190a1-ec0b-6bcc-eb38-2aa5889bbd7d@enterprisedb.com>
Date: Mon, 13 Feb 2023 10:26:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: Consolidate ItemPointer to Datum conversion functions
Content-Language: en-US
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <844dd4c5-e5a1-3df1-bfaf-d1e1c2a16e45@enterprisedb.com>
 <e59df75a-b49f-9597-1e05-0271e3a03861@iki.fi>
 <5f6ed461-331f-47b5-9ce2-90fc660d78f5@enterprisedb.com>
In-Reply-To: <5f6ed461-331f-47b5-9ce2-90fc660d78f5@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/a6a190a1-ec0b-6bcc-eb38-2aa5889bbd7d%40enterprisedb.com>
Precedence: bulk

On 09.02.23 09:33, Peter Eisentraut wrote:
> On 06.02.23 11:11, Heikki Linnakangas wrote:
>> On 06/02/2023 11:54, Peter Eisentraut wrote:
>>> Instead of defining the same set of macros several times, define it once
>>> in an appropriate header file.  In passing, convert to inline functions.
>>
>> Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and 
>> PG_RETURN_ITEMPOINTER, too? They're only used in tid.c, but for most 
>> datatypes, we define the PG_GETARG and PG_RETURN macros in the same 
>> header file as the the Datum conversion functions.
> 
> Yeah that makes sense.  Here is an updated patch for that.

committed