Subject: Re: Preventing abort() and exit() calls in libpq
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>, "daniel@yesql.se"
 <daniel@yesql.se>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 "michael@paquier.xyz" <michael@paquier.xyz>
References: <3128896.1624742969@sss.pgh.pa.us>
 <18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
 <622907.1625084114@sss.pgh.pa.us> <630837.1625092151@sss.pgh.pa.us>
 <67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
 <9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com>
 <745046.1625163264@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com>
Date: Thu, 1 Jul 2021 21:03:58 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <745046.1625163264@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a6c5b570-a7b7-bd0b-59e7-33af54f51dbe%40enterprisedb.com>
Precedence: bulk

On 01.07.21 20:14, Tom Lane wrote:
> The variant of this I'd been thinking of was
> 
>   $(shlib): $(OBJS) | $(SHLIB_PREREQS)
>   	$(LINK.shared) -o $@ $(OBJS) $(LDFLAGS) $(LDFLAGS_SL) $(SHLIB_LINK)
> +ifneq (,$(SHLIB_EXTRA_ACTION))
> +	$(SHLIB_EXTRA_ACTION)
> +endif
> 
> (and similarly in several other places); then libpq's Makefile
> could set SHLIB_EXTRA_ACTION to the desired thing.

Right, that looks sensible.  (Maybe the ifneq isn't actually necessary, 
since if the variable is not set, nothing would happen.)

> The problem then is, what happens when the extra action fails?
> Without .DELETE_ON_ERROR, the shlib is still there and the next
> make run will think everything's good.

Right.  .DELETE_ON_ERROR is already set in Makefile.global, so it's not 
necessary to set it again.