public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Mahendra Singh Thalor <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Srinath Reddy <[email protected]>
Cc: [email protected]
Subject: Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote
Date: Thu, 29 Jan 2026 09:37:36 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKYtNArwMfw1OSTSucZz1ei829xpzMKL50rXDDV02-5Z61Yv-w@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAKYtNArodApzf7OkF49VS4eO-u_Qwy0Pup3FMTw_QoLi5xeczQ@mail.gmail.com>
	<Z_krlRC0ifpW3clw@nathan>
	<CAKYtNAq1-Bu1owjQxQbwZiwx+WwPKkcB2wwd02UkRWehsRnDhw@mail.gmail.com>
	<CAKYtNArwMfw1OSTSucZz1ei829xpzMKL50rXDDV02-5Z61Yv-w@mail.gmail.com>


On 2026-01-20 Tu 1:29 AM, Mahendra Singh Thalor wrote:
> On Tue, 24 Jun 2025 at 11:37, Mahendra Singh Thalor <[email protected]> wrote:
>> On Fri, 11 Apr 2025 at 20:17, Nathan Bossart <[email protected]> wrote:
>>> On Thu, Apr 10, 2025 at 11:58:41PM +0530, Mahendra Singh Thalor wrote:
>>>> As per above discussions, for v18, we will not do any change to server
>>>> side to fix the issue of \n\r in database names. But as a cleanup
>>>> patch, we can give an alert to the user by "pg_upgrade --check". As
>>>> per current code, pg_dump and pg_upgrade will fail with "shell
>>>> command" error but in the attached patch, we will give some extra info
>>>> to the user by "pg_upgrade --check" so that they can fix database
>>>> names before trying to upgrade.
>>>>
>>>> Here, I am attaching a patch which will give a list of invalid
>>>> database names in "pg_upgrade --check". We can consider this as a
>>>> cleanup patch.
>>> Are you proposing this for v18?  I think this is all v19 material at this
>>> point.  Perhaps we could argue this is a bug fix that should be
>>> back-patched, but IMHO that's a bit of a stretch.  I don't sense a
>>> tremendous amount of urgency, either.
>>>
>>> --
>>> nathan
>> Thanks Nathan for the review.
>>
>> I want to re-start this thread for v19. I posted v06* patches in my previous updates[1]. Please someone review it and let me know feedback.
>>
>> v06 patches: v06_patches
>>
>> [1] : https://www.postgresql.org/message-id/CAKYtNAqC5pkjmh8UgvbNLtMyEVeKUtDF3_%2B9dvG9zb8YrhTJQQ%40mail.g...
>>
>> --
>> Thanks and Regards
>> Mahendra Singh Thalor
>> EnterpriseDB: http://www.enterprisedb.com
> Hi,
> Here I am attaching updated patches for the review. Please someone review it.
>
>

These patches need a little copy editing (e.g. 
"check_database_role_names_in_old_cluser" seems to be missing a "t") and 
the error messages and comments need some tidying, but I think they are 
basically sound.

Is there any objection to them in principle?


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox