Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oklqo-0004WD-7W for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Oct 2022 12:37:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oklqm-00072V-1h for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Oct 2022 12:37:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oklql-00072M-N5 for pgsql-hackers@lists.postgresql.org; Tue, 18 Oct 2022 12:37:39 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oklqi-0000jt-5O for pgsql-hackers@postgresql.org; Tue, 18 Oct 2022 12:37:39 +0000 Received: by mail-ej1-x62c.google.com with SMTP id k2so31843961ejr.2 for ; Tue, 18 Oct 2022 05:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=b9miuGUr8TtmzV+g3j4W8rLpg/8zewI8HXZCozlu+5E=; b=WnZzCahMaJf6W6H1aApYiPZuFOeNKSo73Vaw+fD9nmWtwSsGvkClMmNTq4JuvZb7Hz LTk6hbHV+un0ncNZTfJ5KYoG2wUYIlvSYyN+MkNQuiuxafWr7mq7FTtHNFubHAXTb3qy J2r4OZxDEJxk9GI4b3So9pAA3kgCppc/cEaL5GuwhwtgcVQRW2NEnlz1JSRWgXAloRY4 yjK1alJh0cdgGYORuDm+JxffaHpGK5voONgb/cgn/lY0LJGy8X4YRhyG1n9CXsV4PARv TWOS7vWqDGO9RY8zP5PS3KmqeC5LqgkqAWab9HS+zS+EJivaJUmlVzanTJ0o69NpjBew oR+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b9miuGUr8TtmzV+g3j4W8rLpg/8zewI8HXZCozlu+5E=; b=tykLWeETXMhIr8dTeTlFnq7nO16UdZozVhxhn8rwWrLR7bVeTBsI5RppxvS3rPNlGY gcZoOG5WQuy4ptDIgmb4n8/6lFFt0d2IwJugw4d6enxvAxtA+A6EZneQF+a/mabTRsEa W+uPhqyJByYED9KxYdece28/vJMq1WCAgIkIDIkdPvJ6aexX/Xu/DWftFsVvS6acOByJ ItUlwvLH2FNQ8ffjA15PtNmkGjHcR0NO7pwibeKYlQhd+pyvHNcD5qcdmBFZ0CkFc1JN KiMA/m8uqvYHS7NmsujPybZ4Ni8ValG2CW0LDeGNxKrnAc5rBhIcWV4EjwXSrw6oQMKO K7Jw== X-Gm-Message-State: ACrzQf35OkcmFOxO8reukNyehfAsHUwhbNjwPvMwYpxZ/84tytNkvUqy 1GgfgZbDzY0AVJHXOW9UQAk= X-Google-Smtp-Source: AMsMyM7DcWdhGCqRu51LEvZ7ZtvhEFE+X11YWWFLHR2Fk/HzM1m09ovOvSNSOCbVHfAOyzBImgxyxA== X-Received: by 2002:a17:906:5a69:b0:78d:e65b:e5a0 with SMTP id my41-20020a1709065a6900b0078de65be5a0mr2259187ejc.544.1666096654601; Tue, 18 Oct 2022 05:37:34 -0700 (PDT) Received: from [192.168.1.22] ([176.232.103.62]) by smtp.gmail.com with ESMTPSA id e18-20020a17090618f200b007828150a2f1sm7555678ejf.36.2022.10.18.05.37.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Oct 2022 05:37:34 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------ap1CU6LOgOswL7ph8IK7T7xj" Message-ID: Date: Tue, 18 Oct 2022 15:37:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: Mingw task for Cirrus CI Content-Language: en-US To: Melih Mutlu , Andres Freund Cc: Justin Pryzby , pgsql-hackers@postgresql.org, Andrew Dunstan , Thomas Munro References: <20220728224428.GN15006@telsasoft.com> <20220819023356.GT26426@telsasoft.com> <20220905115055.GG31833@telsasoft.com> <20220905235217.5x4qyziidu4ofvzy@awork3.anarazel.de> <20220922170305.wyzzhdrubapsjw3o@awork3.anarazel.de> <20221011182336.vlk57tgn52e3o45q@awork3.anarazel.de> <20221011184612.edxifnqsq7tadxze@awork3.anarazel.de> From: Nazir Bilal Yavuz In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------ap1CU6LOgOswL7ph8IK7T7xj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Thanks for the patch! On 10/18/22 12:49, Melih Mutlu wrote: > > > You can find the updated patch attached. > Does it makes sense to set these at 'Windows - Server 2019, MinGW64 - Meson' task: env:     ...     CHERE_INVOKING: 1     BASH_EXE: C:\msys64\usr\bin\bash.exe 'CHERE_INVOKING: 1' will cause bash.exe to start from current working directory(%CIRRUS_WORKING_DIR%). In this way, there is no need for 'cd %CIRRUS_WORKING_DIR%' when using bash.exe, also no need for 'BUILD_DIR' environment variable. i.e: configure_script: |     %BASH_EXE% -lc "meson setup --buildtype debug -Dcassert=true -Db_pch=true -DTAR=%TAR% build" will work. Regards, Nazir Bilal Yavuz --------------ap1CU6LOgOswL7ph8IK7T7xj Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi,

Thanks for the patch!
On 10/18/22 12:49, Melih Mutlu wrote:


You can find the updated patch attached.


Does it makes sense to set these at 'Windows - Server 2019, MinGW64 - Meson' task:

env:
    ...
    CHERE_INVOKING: 1
    BASH_EXE: C:\msys64\usr\bin\bash.exe

'CHERE_INVOKING: 1' will cause bash.exe to start from current working directory(%CIRRUS_WORKING_DIR%).

In this way, there is no need for
'cd %CIRRUS_WORKING_DIR%' when using bash.exe,
also no need for 'BUILD_DIR' environment variable.

i.e:

configure_script: |
    %BASH_EXE% -lc "meson setup --buildtype debug -Dcassert=true -Db_pch=true -DTAR=%TAR% build"

will work.

Regards,
Nazir Bilal Yavuz
--------------ap1CU6LOgOswL7ph8IK7T7xj--