Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pCHyG-0000Gk-Vd
	for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Jan 2023 10:23:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pCHyE-0008Ro-MF
	for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Jan 2023 10:23:06 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <peter.eisentraut@enterprisedb.com>)
	id 1pCHyD-0008Rf-GH
	for pgsql-hackers@lists.postgresql.org; Mon, 02 Jan 2023 10:23:06 +0000
Received: from new3-smtp.messagingengine.com ([66.111.4.229])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <peter.eisentraut@enterprisedb.com>)
	id 1pCHy9-0006ZP-FX
	for pgsql-hackers@postgresql.org; Mon, 02 Jan 2023 10:23:04 +0000
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
	by mailnew.nyi.internal (Postfix) with ESMTP id 758CC5809ED;
	Mon,  2 Jan 2023 05:23:00 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
  by compute1.internal (MEProxy); Mon, 02 Jan 2023 05:23:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:feedback-id:feedback-id:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672654980; x=
	1672662180; bh=5n9gS3OMrWxlwD39KleRwMP9fULD0J4t/npwxmIrI5c=; b=e
	NQVwOm/kmZVwi+n/kbmTi+fFDufGCXXEji0j07Cax/XH27xhJzE3wLp71YwqSnIE
	Z3aTkHnLl6ydmCzzGdQIx2drw5PYdR9hX1JZt52BiV8K8P19uILIwllqsDqkRBl9
	zoE9WfwzlYlqyrcP6pPAoKQH2b5arL9RgNbYmm/kZ/OXPApMqcSNLidOpCRitSJi
	yNqxYtnn1gD1NX42zNmX/yPnFmoLTwnY/FR537FPZrSOmGqLd5VREEgv3Fg00T+m
	/zW3duI7M9Oy2vPC1QdUYevlyAuujlEzOgNfsgMruYdEM3FESGy5XvRKrCgS7CPP
	lKYJkOuIMWHD65Tmoj+aw==
X-ME-Sender: <xms:g7CyY9U6_n2VxTFIul6DxWdQ8THy3gbiRS5NwioaeFfPkiZ5mnfkEQ>
    <xme:g7CyY9mGbEjoy1CjyWhPumTQIDvYC2UiW0sxZAAldXV2nMvHupgL7RF92OQ5En6zQ
    h3DZqmjRTb13Ii11A>
X-ME-Received: <xmr:g7CyY5a4yMxVkgZ2ws5aB2OdBRrzx2eEoaGeDu6UE0-ESRikJLDVYptvtoqFOu7VjkLH3wMWHQTjcnD7HrMhijS1-uFqusJZWA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgdduhecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv
    rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg
    hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepheelffeggedujeetiefh
    leetuddvieffhfffvdejvdffgeejkeduleduheduieefnecuvehluhhsthgvrhfuihiivg
    eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht
    segvnhhtvghrphhrihhsvggusgdrtghomh
X-ME-Proxy: <xmx:g7CyYwXIeAp26pwcr3C_VCtTgL0x4jIkfbG5XCzlUl7g5LfxKtAZDw>
    <xmx:g7CyY3lsAfA2H8uzGY2sDhBkueWJZndl2HkXl0PZRLxBDzExa9Yo3g>
    <xmx:g7CyY9eBguZC1tGZqnTnS2dgzUJJXtmFvf43LAT2j8z2TA83NpJBcA>
    <xmx:hLCyYwcPcAqOZB3Mmzbq8tuvfk6hUY145y4oroPlvmbGWND9f05GIA>
Feedback-ID: i131946ab:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 2 Jan 2023 05:22:59 -0500 (EST)
Message-ID: <a791e959-a01a-1837-d618-8bfaa7d7cd21@enterprisedb.com>
Date: Mon, 2 Jan 2023 11:22:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.0
Subject: Re: heapgettup refactoring
Content-Language: en-US
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <CAAKRu_YSOnhKsDyFcqJsKtBSrd32DP-jjXmv7hL0BPD-z0TGXQ@mail.gmail.com>
 <20221101010948.hsf33emgnwzvil4a@awork3.anarazel.de>
 <CAAKRu_ZJg_N7zHtWP+JoSY_hrce4+GKioL137Y2c2En-kuXQ7g@mail.gmail.com>
 <8ac6e414-4b77-d4e9-c076-de2c41fbff2c@enterprisedb.com>
 <CAAKRu_bWPFT8ZX5pTw0nm_rpBrivSjB3wMntqnHNDwJAV1LdsA@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CAAKRu_bWPFT8ZX5pTw0nm_rpBrivSjB3wMntqnHNDwJAV1LdsA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/a791e959-a01a-1837-d618-8bfaa7d7cd21%40enterprisedb.com>
Precedence: bulk

On 30.11.22 23:34, Melanie Plageman wrote:
> I have attached a patchset with only the code changes contained in the
> previous patch 0003. I have broken the refactoring down into many
> smaller pieces for ease of review.

To keep this moving along a bit, I have committed your 0002, which I 
think is a nice little improvement on its own.