Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzjZr-0000s7-Gt for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 14:55:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gzjZq-0000xu-6v for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 14:55:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzjZp-0000xn-Un for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2019 14:55:53 +0000 Received: from mail-qt1-f173.google.com ([209.85.160.173]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzjZn-0006ql-4Z for pgsql-hackers@postgresql.org; Fri, 01 Mar 2019 14:55:53 +0000 Received: by mail-qt1-f173.google.com with SMTP id o6so28014280qtk.6 for ; Fri, 01 Mar 2019 06:55:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nAYTc2USzohtpigaRz7hGNxasr4zw+8f4jBZPxHsoys=; b=Tp66h+xxBO7C1mVzMQUVMFIVJHMNksjL0twX1DmJ9z7LYFWanAkft/aO0ntI25DOhz pF3q361F4Qjyx/sCuK0aSo2AdHbCBbPgQ2y9wRlPqtAAaAt4KTSMC9HZBjzDLEO9kyZV 6FEDKQE9HEsUl7YmGg6mk5ryG/F+JxdvzDQ8221tqkBlPjnfvh9a67Ra/KL7NO7hSEWC 1uybLmh7JBLO3/kCA0/qEDFSB5XPu462v+PAjN682fj5WyrlTRiRzPE++UH0MHetaror CvrBY5SPZaoJWuuXBABci10a04UuyMs0g5pRzQx5N8AcGpMvzIboAavOj2sW4mDiGtQT J8Lg== X-Gm-Message-State: APjAAAUJbTr6I6+FpIi2Y0CbNqWVTwQT+kpm7e5r+p3EUV42R9tMeFra 0BtRaTzCQg7701Ry2uam3DbYw4c8+wY= X-Google-Smtp-Source: APXvYqzIoeXx1MFJ5DLF7v1OyVkqBA8wngyYkNZve55C9anQenjPy+0bzuljnyyuMs99tnxHkBvfGw== X-Received: by 2002:ac8:16ec:: with SMTP id y41mr4228526qtk.333.1551452147960; Fri, 01 Mar 2019 06:55:47 -0800 (PST) Received: from localhost.localdomain (c-24-61-8-151.hsd1.ma.comcast.net. [24.61.8.151]) by smtp.gmail.com with ESMTPSA id j189sm11470105qkc.77.2019.03.01.06.55.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 06:55:47 -0800 (PST) Reply-To: jesper.pedersen@redhat.com Subject: Re: partitioned tables referenced by FKs To: Alvaro Herrera Cc: Amit Langote , Pg Hackers References: <20190228182804.GA24555@alvherre.pgsql> From: Jesper Pedersen Organization: Red Hat Message-ID: Date: Fri, 1 Mar 2019 09:55:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190228182804.GA24555@alvherre.pgsql> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Alvaro, On 2/28/19 1:28 PM, Alvaro Herrera wrote: > Rebased to current master. I'll reply later to handle the other issues > you point out. > Applying with hunks. With 0003 using export CFLAGS="-DCOPY_PARSE_PLAN_TREES -O0 -fno-omit-frame-pointer" && CC="ccache gcc" ./configure --prefix /usr/local/packages/postgresql-12.x --enable-dtrace --with-openssl --with-gssapi --with-libxml --with-llvm --enable-debug --enable-depend --enable-tap-tests --enable-cassert I'm getting a failure in the pg_upgrade test: -- +-- Name: pk5 pk5_pkey; Type: CONSTRAINT; Schema: regress_fk; Owner: jpedersen +-- + +ALTER TABLE ONLY regress_fk.pk5 + ADD CONSTRAINT pk5_pkey PRIMARY KEY (a); + + +-- when running check-world. Best regards, Jesper