Feedback-ID: ie0a040ee:Fastmail
Message-ID: <a7bee080-ca35-f49e-1ef1-41484f529c37@eisentraut.org>
Date: Thu, 5 Oct 2023 17:49:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: tablecmds.c/MergeAttributes() cleanup
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20230829112028.qhzse7chs3swqwqh@alvherre.pgsql>
 <60beec03-f14c-ea46-8e5f-f68773ce83f9@eisentraut.org>
In-Reply-To: <60beec03-f14c-ea46-8e5f-f68773ce83f9@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/a7bee080-ca35-f49e-1ef1-41484f529c37%40eisentraut.org>
Precedence: bulk

On 19.09.23 15:11, Peter Eisentraut wrote:
> Here is an updated version of this patch set.  I resolved some conflicts 
> and addressed this comment of yours.  I also dropped the one patch with 
> some catalog header edits that people didn't seem to particularly like.
> 
> The patches that are now 0001 through 0004 were previously reviewed and 
> just held for the not-null constraint patches, I think, so I'll commit 
> them in a few days if there are no objections.
> 
> Patches 0005 through 0007 are also ready in my opinion, but they haven't 
> really been reviewed, so this would be something for reviewers to focus 
> on.  (0005 and 0007 are trivial, but they go to together with 0006.)
> 
> The remaining 0008 and 0009 were still under discussion and contemplation.

I have committed through 0007, and I'll now close this patch set as 
"Committed", and I will (probably) bring back the rest (especially 0008) 
as part of a different patch set soon.