Subject: Re: MultiXact\SLRU buffers configuration
To: "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Daniel Gustafsson <daniel@yesql.se>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <3B099683-ECCD-43CD-A3D6-F08C3745002A@yandex-team.ru>
 <20200514.151659.1224056315528271804.horikyota.ntt@gmail.com>
 <102F673B-C9C5-4823-A92F-96799FC61ED0@yandex-team.ru>
 <20200515.090333.24867479329066911.horikyota.ntt@gmail.com>
 <BA079D14-8D11-4A73-B6EC-FE393C712439@yesql.se>
 <2ECE132B-C042-4489-930E-DBC5D0DAB84A@yandex-team.ru>
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Message-ID: <a7f1c4e1-1015-92a4-2bd4-6736bd13d03e@postgrespro.ru>
Date: Fri, 28 Aug 2020 21:08:34 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <2ECE132B-C042-4489-930E-DBC5D0DAB84A@yandex-team.ru>
Content-Type: multipart/mixed;
 boundary="------------3CF0588B8103FC976B44B226"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------3CF0588B8103FC976B44B226
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On 08.07.2020 10:03, Andrey M. Borodin wrote:
>
>> 2 июля 2020 г., в 17:02, Daniel Gustafsson <daniel@yesql.se> написал(а):
>>
>>> On 15 May 2020, at 02:03, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
>>> Generally in such cases, condition variables would work.  In the
>>> attached PoC, the reader side gets no penalty in the "likely" code
>>> path.  The writer side always calls ConditionVariableBroadcast but the
>>> waiter list is empty in almost all cases.  But I couldn't cause the
>>> situation where the sleep 1000u is reached.
>> The submitted patch no longer applies, can you please submit an updated
>> version?  I'm marking the patch Waiting on Author in the meantime.
> Thanks, Daniel! PFA V2
>
> Best regards, Andrey Borodin.

1) The first patch is sensible and harmless, so I think it is ready for 
committer. I haven't tested the performance impact, though.

2) I like the initial proposal to make various SLRU buffers 
configurable, however, I doubt if it really solves the problem, or just 
moves it to another place?

The previous patch you sent was based on some version that contained 
changes for other slru buffers numbers: 'multixact_offsets_slru_buffers' 
and 'multixact_members_slru_buffers'. Have you just forgot to attach 
them? The patch message "[PATCH v2 2/4]" hints that you had 4 patches)
Meanwhile, I attach the rebased patch to calm down the CFbot. The 
changes are trivial.

2.1) I think that both min and max values for this parameter are too 
extreme. Have you tested them?

+               &multixact_local_cache_entries,
+               256, 2, INT_MAX / 2,

2.2) MAX_CACHE_ENTRIES is not used anymore, so it can be deleted.

3) No changes for third patch. I just renamed it for consistency.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--------------3CF0588B8103FC976B44B226
Content-Type: text/x-patch; charset=UTF-8;
 name="v3-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-offs.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="v3-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-offs.pa";
 filename*1="tch"