Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fviZJ-0001E9-Ot for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Aug 2018 12:30:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fviZH-0005d1-99 for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Aug 2018 12:30:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fviZH-0005ct-27 for pgsql-hackers@lists.postgresql.org; Fri, 31 Aug 2018 12:30:27 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fviZ7-0006FJ-CF for pgsql-hackers@postgresql.org; Fri, 31 Aug 2018 12:30:25 +0000 Received: from pool-98-113-6-186.nycmny.east.verizon.net ([98.113.6.186] helo=Ph33r-Retina.home) by meldrar.postgresql.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fviZ3-0000Cd-5d; Fri, 31 Aug 2018 12:30:17 +0000 Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. To: Etsuro Fujita Cc: Michael Paquier , Robert Haas , Amit Langote , Tom Lane , Andres Freund , Ashutosh Bapat , Rajkumar Raghuwanshi , pgsql-hackers References: <5B717A7B.4010308@lab.ntt.co.jp> <5B739D46.6040000@lab.ntt.co.jp> <3585ad1d-d610-ad53-80e2-296050cd73f3@lab.ntt.co.jp> <5B74101B.9080402@lab.ntt.co.jp> <5B74E8C0.5040300@lab.ntt.co.jp> <5B7D4449.9090704@lab.ntt.co.jp> <5B7EB001.4010907@lab.ntt.co.jp> <20180824024710.GH30782@paquier.xyz> <5B7FFC58.7060208@lab.ntt.co.jp> <5B8669F3.2070905@lab.ntt.co.jp> <5B87D414.5030702@lab.ntt.co.jp> <5B892C65.9050008@lab.ntt.co.jp> From: "Jonathan S. Katz" Openpgp: preference=signencrypt Autocrypt: addr=jkatz@postgresql.org; keydata= xsFNBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABzTFKb25hdGhhbiBT LiBLYXR6IDxqb25hdGhhbi5rYXR6QGV4Y292ZW50dXJlcy5jb20+wsGXBBMBCABBAhsDBQkH hh+ABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEE+oS2la8r95ogZD/x8QSccp8cZScFAltS iSUCGQEACgkQ8QSccp8cZSfqrQ//bcMXxIqELT+DMa2C5IR4K3kRsdgxC2mcdsO4XgRxNLQF uZYqKa85EEZ+O4O/oHV5AgckWRcxCUNI0qafwC+QNTc/lBecmMipbP1X2+A8RBiTBRpSgo9y BOQ2xmA70k32Rk4hLd9EVTb0eXe9DoJIXWOsMlqqpqEuXiaoH5a2Ww6DdpCMN1vQZ/HavbAG cXV3MXahiqmBhH6Y0v1kZTJYEOCw0w4U1Q/vdUKw9/jv+fidU6I/jafHAxda7pI+dtNOyUtC bmv+9+KreUeBqyBXGmNFDZ4wa4TvYfaw6VV3acNT5KgcefQpd7JlzM+Vq3zz1tnR4C50nEpg DEpf0ANyeZ48v5+M7ycoIbxAHzwzKsiTaVmMDYRdnxmlv18UaWc/wmoI0wFAtcGjfw5KJLQv oolZYP18S0mpH2Q8SxcXbqekDvsHVW04Jkult9xZSeijdzUzcumflCZ2Y5VQKNjG99eZh5Iq JcUdYJH5mdmdFWgZdYTT6tZWHCMBBDBqktzLmyBezrqT0+j3E5lL/30tkatrcDkNPd3lE/j1 OxG10xVvCqzBvksBR0VX/RLKmj2wvIMqKoCav1GgBIdVAuLSO4CyWkWRRawpcREwUvNKyL2E uPXqsqTzYrYRxUM7GmjY3x40/IiA0uJCuxYEIeelmOwFEnadvyFUJxseVsczl/DOwU0EW1KH AAEQAL/IaP7aEPQxt4+H/YfZ9WkR69hZb4jdlLacui/PnXw4IDtIHopZpBkDqJWdhOtIBn8n v5FLRfVtzQcjuIcQ0fbuqmzl3Hap7gPnHOvBH6pVhSa1bWBcbdIeBJVmDmJyHsyrYa4lnIfx WO9BRq8bN8/FBzh6udMAVuN93k72ZvdFosQYlxLdr9Q4FuFa98pnzuwGqfyGMj7hOCc4LnQL gJdByj8jRB1hxtXQG419UYgsPYJJyA1kDhdAeFAGiXLVhlXJ2dwNlC8DRjGtT/WSZQVn9b3I 9NWohzFNMkOyYyYkqb35vXjNLki8EXQ6yY8peWWalbpo3b9kjDUPBr2EWxDMrNxhg0rfc14H wklJz5yX2MY8wR0SOseOFn7MfEuoVsXqTqIAiSf4OuwZPZmPGFeJJViFwyVTi+Y5wQtPQ27G RvNSWhNkMQfGO1t+mTK6IvVzMYN7PNOYUAEFL3Rv6aFPITfAVna505v/uHkEKe4A2NXjw5hj OmyQvjhzkpxbUf3/u9M6SiddHHO3AcoBp5dckdyo4RcgFlBbz+GRs4ignKTMF2X3vTxrsgP2 DrmzKYcSJ92LCtsK3X2imWF9hjGQmYTDHL8fSKUK8SCYFPlZcF7vzvi5NdFSD3MTyScJqXSO h83EvGYBuiDHAuOOF107i2j/I9poHDL2GpN0nAspABEBAAHCwXwEGAEIACYWIQT6hLaVryv3 miBkP/HxBJxynxxlJwUCW1KHAAIbDAUJB4YfgAAKCRDxBJxynxxlJ0XjD/0QNlIRkI/huLgb IZES46UcrGm3T6oEAXRAZOsGG4qPPFoP9v4YGO1M5gwxMF97GX0A3KyOvryKGyPLqrLWSA/l oAAGtSS3woTMlUJ0stM31jDgAV7HHObRrrxUWbyZJU4rLDBY11MGkRBCqeGYpE7yf+tjAo0n ba1IZzy76E7B0ykSg4nIRPm+QOeGpcLLm04o8Ndjujdtq+SI2YokmVdLu3bEocisPu8Akmsf X7gaBONzTGH/nZ4zCp3qwEGFHGVmDJ5PhAvEWqmAMb+l2drSsdQJBhpLcJECAcK8/SJQ0ryd y1idlCCLi0U3Z4DYIBiC+M87lGtheeharJECLmDGjRE5Oi2H2pQQ0Ok1SwHIAj0MaeJOIvz0 bGd5WdmYUR0WHIjr5pKfiOhHx8JZUKWK1rNbYZbgRqpSUlSYCpdCDhbyi7EOiin6swMIehca zuamo6eL4jSILVqBcDuQadI4BU2x9jqzFiEX1HVAh9Q427qOubL4TY+xTbEFWMxwyPjXdSPy zgaD3N1KK0TBdjOCVZFEe7JDh1lGz00jVK+6nNeDUjGNzyoxnlRgLAVRwT75kcf0rNrVv06S VqcYOKZqrhUEl7mmIWH+BTfEsct9tKXK/hajfAIWZGCXDWPNjk7UeVRCkQv5mHMqutalyCqp 4MnZ+/WyYxsR4qcchRZhAg== Message-ID: Date: Fri, 31 Aug 2018 08:30:06 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <5B892C65.9050008@lab.ntt.co.jp> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jiGjNpDP3HgfpIOF0x1ZhGduRkLVn4pZL" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jiGjNpDP3HgfpIOF0x1ZhGduRkLVn4pZL Content-Type: multipart/mixed; boundary="N3WLJsN4QVwzA23JFq3V4AWFQ4GlhEaks"; protected-headers="v1" From: "Jonathan S. Katz" To: Etsuro Fujita Cc: Michael Paquier , Robert Haas , Amit Langote , Tom Lane , Andres Freund , Ashutosh Bapat , Rajkumar Raghuwanshi , pgsql-hackers Message-ID: Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. References: <5B717A7B.4010308@lab.ntt.co.jp> <5B739D46.6040000@lab.ntt.co.jp> <3585ad1d-d610-ad53-80e2-296050cd73f3@lab.ntt.co.jp> <5B74101B.9080402@lab.ntt.co.jp> <5B74E8C0.5040300@lab.ntt.co.jp> <5B7D4449.9090704@lab.ntt.co.jp> <5B7EB001.4010907@lab.ntt.co.jp> <20180824024710.GH30782@paquier.xyz> <5B7FFC58.7060208@lab.ntt.co.jp> <5B8669F3.2070905@lab.ntt.co.jp> <5B87D414.5030702@lab.ntt.co.jp> <5B892C65.9050008@lab.ntt.co.jp> In-Reply-To: <5B892C65.9050008@lab.ntt.co.jp> --N3WLJsN4QVwzA23JFq3V4AWFQ4GlhEaks Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 8/31/18 7:54 AM, Etsuro Fujita wrote: > (2018/08/30 20:25), Etsuro Fujita wrote: >> (2018/08/29 18:40), Etsuro Fujita wrote: >>> (2018/08/29 0:21), Jonathan S. Katz wrote: >>>>> On Aug 24, 2018, at 8:38 AM, Etsuro >>>>> Fujita wrote: >>>>> (2018/08/24 11:47), Michael Paquier wrote: >>>>>> On Thu, Aug 23, 2018 at 10:00:49PM +0900, Etsuro Fujita wrote: >>>>>>> I tried this today, but doing git behind the corporate firewall >>>>>>> doesn't >>>>>>> work. I don't know the clear cause of that, so I'll investigate >>>>>>> that >>>>>>> tomorrow. >>>>>> >>>>>> You may be able to tweak that by using https as origin point or >>>>>> proper >>>>>> git proxy settings? >>>>> >>>>> Yeah, my proxy settings were not correct. With the help of my >>>>> colleagues Horiguchi-san and Yamada-san, I corrected them but still= >>>>> can't clone the master repository. Running git with GIT_CURL_VERBOS= E >>>>> shows that there is another issue in my terminal environment, so I'= m >>>>> trying to resolve that. >>>> >>>> Are there any updates on getting this patch committed? >>> >>> That investigation has shown that the cause is my company firewall, n= ot >>> my terminal environment; that firewall has to be configured to allow = me >>> to access to that repository. So, I'm asking my company about that. >> >> I got the approval from my boss today, so I think that I can have that= >> access soon. > > I fixed typos in the commit message, which Alvaro pointed out > off-list, and revised the message a little bit.=C2=A0 Also, I reread th= e > patch and noticed that the latest version includes now-unnecessary > regression test cases; those were added to the previous version > (refuse-pwj-when-wrvs-involved-2.patch in [1]) to check that > apply_scanjoin_target_to_paths() and create_ordinary_grouping_paths() > work for cases where whole-row Vars are involved, because I modified > those functions, but the latest version doesn't touch those functions > anymore, so those test cases seems unnecessary.=C2=A0 So I removed thos= e > (no other changes), and committed the patch. Thank you for taking care of that and for committing the patch. I have now closed this issues on the open items list. Jonathan --N3WLJsN4QVwzA23JFq3V4AWFQ4GlhEaks-- --jiGjNpDP3HgfpIOF0x1ZhGduRkLVn4pZL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAluJNM8ACgkQ8QSccp8c ZSeuwQ/+JW468uaaKJM2F7nrOngNaFneqZnNQnjLtfSwhxwT6idKbNZyF0jqsct7 OM+osz0EoeLtr181Liab7AmhNXOS9lOPOPjNv5RnnQAdiTuzt49pemj9YeivSX7v 15VFtT6yxuYpQJMEHnbqa0/PU3918GbMAbo07cSGubS/9Pv4GxmYWyO9CC9Vr1RH qNff2sPy9eoenqRR6mxJDIrulPTAcc8A+kvpro33YHd8ra+6a/py+9e3R1uGnUzu ZafWu/Rl8QsO6N6gtIqUMvqa9p5NG8mO3NQkBgZyfVHJIABW7O2FgpvjRIZEyChM MLhpLztWqgh12oBzH5iMTr5e/QUtoiT7ufvXYBgONPZ5HK6SSaM/+SqmVGZLKc4H vwg8npHRrpyTnPQf2JqjLxxlUfq8iHDHC6ZPOAioCXH8G14+gwG+v7nLgwolRRES EyIFv0d7hgrMVtmwlTpSjVYi0hU9oKjJzpCFxxIZmmWDuoWB8/QaMbk71h4vAsQp ThmmrjhGV+2wqEEcNSvFCDom0yPDycRfBIGCKLBd/i4GbGJ6vfY8Wfe2p+jWCc5W OJ2yYnnSV3KP4NHDbHg604hb707BKOLgDdOk2vgq++6VuqCB93ERANUfSqE29LDL rl2Mwgmusv4H2gSaQIJpg2TFWSa76ZL3EyYpRAJ68mO1UhwZz/M= =IzjN -----END PGP SIGNATURE----- --jiGjNpDP3HgfpIOF0x1ZhGduRkLVn4pZL--