Message-ID: <a873643c-e7d1-456c-b16b-6162ab698036@oss.nttdata.com>
Date: Fri, 19 Jul 2024 22:03:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add new COPY option REJECT_LIMIT
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <63f99327aa6b404cc951217fa3e61fe4@oss.nttdata.com>
 <fab7018f-6e00-4be4-bd1e-4a013096f6c9@oss.nttdata.com>
 <de0551d0f9d9e9072e324e51ed5c426d@oss.nttdata.com>
 <6e3dcdc6-8e18-4716-a23b-3bee316aeaa7@oss.nttdata.com>
 <979c6d306343f3d665d14eab2cd1b7bc@oss.nttdata.com>
 <920a29a36032befbeb355cbdfbbe0f63@oss.nttdata.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <920a29a36032befbeb355cbdfbbe0f63@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a873643c-e7d1-456c-b16b-6162ab698036%40oss.nttdata.com>
Precedence: bulk


On 2024/07/17 22:21, torikoshia wrote:
> On 2024-07-03 02:07, Fujii Masao wrote:
>> However, if we support REJECT_LIMIT, I'm not sure if the ON_ERROR option is still necessary.
> 
> I remembered another reason for the necessity of ON_ERROR.
> 
> ON_ERROR defines how to behave when encountering an error and it just accepts 'ignore' and 'stop' currently, but is expected to support other options such as saving details of errors to a table[1].

Wouldn't it be better to separate the option specifying where
error details are output from the ON_ERROR option
(which determines behavior when encountering errors)?
"table" seems valid for both ON_ERROR=ignore and ON_ERROR=stop.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION