Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1egARG-0001o7-V8 for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jan 2018 14:29:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egARF-0007Mf-I8 for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jan 2018 14:29:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1egARF-0007MU-26 for pgsql-hackers@lists.postgresql.org; Mon, 29 Jan 2018 14:29:37 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1egARB-0000Na-8O for pgsql-hackers@postgresql.org; Mon, 29 Jan 2018 14:29:35 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 3878221C1C49; Mon, 29 Jan 2018 17:29:30 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [192.168.27.109] (gw.postgrespro.ru [93.174.131.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id D037121C1C48; Mon, 29 Jan 2018 17:29:29 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1517236170; bh=lorGCWwepr5IgPTCrNwYBgnYkitP2UhE83bmZjBM87I=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=FMZC+HAQvPRZJXf7AMxyLdEC3QM/oKy9VaEr7QYgthrZ95pgmTrB3x/3sTEXI2/Ae yuUwIUZ3j6qLGx8Ojd9JYk2nB5lFsZ1/21ZTk9f3043yiQZgby06dOK1K8UWsT1+Mi PopBz7dqp7l5u5qa6tE45V4xikw19nZVzwlhB+UU= Subject: Re: [HACKERS] Custom compression methods To: Ildus Kurbangaliev References: <20171201194859.le5hvnnrjzhxhm2t@alvherre.pgsql> <20171211155555.05ddd2fc@postgrespro.ru> <20171213151818.75a20259@postgrespro.ru> <20171218115431.2b3e29ba@wp.localdomain> <20180115024930.48583c69@hh> <0633c6e5-5328-5c5b-708b-c4409e3fd131@postgrespro.ru> <20180123160454.131ade09@wp.localdomain> <6fd5dea3-8889-c7bb-9df2-79493b2b6ab0@postgrespro.ru> <20180125172457.5967c022@wp.localdomain> <20180129144452.08f04dc3@wp.localdomain> Cc: Robert Haas , Alexander Korotkov , Tomas Vondra , Alvaro Herrera , =?UTF-8?B?0JXQstCz0LXQvdC40Lkg0KjQuNGI0LrQuNC9?= , Andres Freund , Oleg Bartunov , Craig Ringer , Peter Eisentraut , PostgreSQL Hackers , Chapman Flack From: Ildar Musin Message-ID: Date: Mon, 29 Jan 2018 17:29:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20180129144452.08f04dc3@wp.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hello Ildus, On 29.01.2018 14:44, Ildus Kurbangaliev wrote: > > Thanks! Attached new version of the patch. > Patch applies cleanly, builds without any warnings, documentation builds ok, all tests pass. A remark for the committers. The patch is quite big, so I really wish more reviewers looked into it for more comprehensive review. Also a native english speaker should check the documentation and comments. Another thing is that tests don't cover cmdrop method because the built-in pglz compression doesn't use it (I know there is an jsonbd extension [1] based on this patch and which should benefit from cmdrop method, but it doesn't test it either yet). I think I did what I could and so passing this patch to committers for the review. Changed status to "Ready for committer". [1] https://github.com/postgrespro/jsonbd -- Ildar Musin i.musin@postgrespro.ru