Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m39r6-0002uf-2q for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jul 2021 04:17:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m39r5-0001uB-1g for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jul 2021 04:17:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m39r4-0001rp-2D for pgsql-hackers@lists.postgresql.org; Tue, 13 Jul 2021 04:17:10 +0000 Received: from wforward3-smtp.messagingengine.com ([64.147.123.22]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m39r1-0006V3-1u for pgsql-hackers@lists.postgresql.org; Tue, 13 Jul 2021 04:17:08 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailforward.west.internal (Postfix) with ESMTP id 143D51AC1A16; Tue, 13 Jul 2021 00:17:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 13 Jul 2021 00:17:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zlEz0MrxpnzQ3iuL8Sm56nhJcECB2r5zwHsoNIL8c AQ=; b=p7q8064K6F9GXEQA/MwA1XrZlNfYEIZKIzjgC7y3aBA1lUZ8QbFKIRcUX 3ai7h2xRAGG7FMLq7mUbiAO7dSXSPaLLMJB9oWnMe+zJI/lb6esrxk1K5v/BjLMR r3pjR1YIf6ZPfEZgcYfVi68N2uf6fh3+6UMbWq1Gvkmekuqtmx7Y9KiH5l7eUpev 7k+4SASMo5saPK8SaSlSP8DZ0QY53CuVBSW30PWRLJ8Lv07MaVlBNg3ImhO2uB9K dHTUP37KA5QqCYnmA7FEJIXFSM+R1sX3ZNwt8+Cne2pZyJgOEf3tJx6wgWQ/Fopk d9SLooVF3vIBiG/MhcxzmkD7ANjnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeggdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhkffffgggjggtgfesthejre dttdefheenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdr vghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomheqnecuggftrfgrth htvghrnhephfefleefueevuddvffehjedtjeejgfelhfdtvdffheeludetudegfeeftdff ffejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepph gvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Jul 2021 00:17:03 -0400 (EDT) Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm To: Tom Lane , pgsql-hackers@lists.postgresql.org References: <3185430.1626133592@sss.pgh.pa.us> From: Peter Eisentraut Message-ID: Date: Tue, 13 Jul 2021 06:17:01 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3185430.1626133592@sss.pgh.pa.us> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 13.07.21 01:46, Tom Lane wrote: > Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever > as 1 or 0, but some of the entries in msvc/Solution.pm show > such symbols as "undef" instead. Shouldn't we fix it as > per attached? This is probably only cosmetic at the moment, > but it could bite us someday if someone wrote a complex > conditional using one of these symbols. Yes, I think that is correct.