public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: [email protected] <[email protected]>
To: [email protected] <[email protected]>
Subject: Re: [PATCH]Add tab completion for foreigh table
Date: Thu, 13 Jan 2022 12:38:12 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS0PR01MB61137E96E0551278782D11CDFB519@OS0PR01MB6113.jpnprd01.prod.outlook.com>
References: <OS0PR01MB61137E96E0551278782D11CDFB519@OS0PR01MB6113.jpnprd01.prod.outlook.com>



On 2022/01/11 21:43, [email protected] wrote:
> Hi
> 
> Attached a patch to improve the tab completion for foreigh table.

Thanks!

Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE FOREIGN TABLE?


> Also modified some DOC description of ALTER TABLE at [1] in according with CREATE INDEX at [2].
> 
> In [1], we use "ALTER INDEX ATTACH PARTITION"
> In [2], we use "ALTER INDEX ... ATTACH PARTITION"
> 
> I think the format in [2] is better.

Agreed.

IMO it's better to make the docs changes in separate patch because they are not directly related to the improvement of tab-completion.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH]Add tab completion for foreigh table
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox