public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Verite <[email protected]>
To: Anthonin Bonnefoy <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add Pipelining support in psql
Date: Wed, 05 Mar 2025 15:25:12 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAO6_Xqroaof=Gu_NCg4bZfpdgwOjNW9fg753cuuts-FBnv9UGw@mail.gmail.com>
Anthonin Bonnefoy wrote:
> So if I understand correctly, you want to automatically convert a
> simple query into an extended query when we're within a pipeline. That
> would be doable with:
>
> --- a/src/bin/psql/common.c
> +++ b/src/bin/psql/common.c
> @@ -1668,7 +1668,16 @@ ExecQueryAndProcessResults(const char *query,
> }
> break;
> case PSQL_SEND_QUERY:
> - success = PQsendQuery(pset.db, query);
> + if (PQpipelineStatus(pset.db) != PQ_PIPELINE_OFF) {
> + success = PQsendQueryParams(pset.db, query,
> +
> pset.bind_nparams, NULL,
> + (const
> char *const *) pset.bind_params,
> + NULL, NULL,
> 0);
> + if (success)
> + pset.piped_commands++;
> + }
> + else
> + success = PQsendQuery(pset.db, query);
> break;
> }
Yes, except that the bind parameters need to be cleared after this,
as done in clean_extended_state()
> I do see the idea to make it easier to convert existing scripts into
> using pipelining. The main focus of the initial implementation was
> more on protocol regression tests with psql, so that's not necessarily
> something I had in mind.
Understood. Yet pipelining can accelerate considerably certain scripts
when client-server latency is an issue. We should expect end users to
benefit from it too.
> I have some reservation as it will push all
> parameters in the query string which may not be the desired
> behaviour.
I don't follow. For me the change discussed here is about simplifying
the syntax when there is no out-of-query $N-style parameters, it does
not change anything for queries that actually use them, nor does
it forbid a \bind without parameters.
Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add Pipelining support in psql
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox