Message-ID: <a984fb94-0694-4b70-9fbb-8562acb4e8f1@gmail.com>
Date: Mon, 16 Mar 2026 11:16:30 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Avoid resource leak (contrib/postgres_fdw/connection.c)
To: Ranier Vilela <ranier.vf@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: 
 <CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg+1DGrag@mail.gmail.com>
Content-Language: en-US
From: Matheus Alcantara <matheusssilv97@gmail.com>
In-Reply-To: 
 <CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg+1DGrag@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a984fb94-0694-4b70-9fbb-8562acb4e8f1%40gmail.com>
Precedence: bulk

On 16/03/26 08:45, Ranier Vilela wrote:
> Hi.
> 
> Per Coverity.
> 
> CID 1645716: (#1 of 1): Resource leak (RESOURCE_LEAK)
> 8. leaked_storage: Variable str going out of scope leaks the storage
> str.data points to.
> 
> The function *postgres_fdw_connection* leaks the contents of
> var str.data
> Once that function *cstring_to_text* palloc the contents
> must be necessary to free the var str.data.
> 
> patch attached.
> 

Hi,

Thanks for the patch, it looks correct to me. I've searched for this 
pattern `PG_RETURN_TEXT_P(cstring_to_text(.*.data` in other places and 
I've just found on postgres_fdw/connection.c

I've also search for other cases of `return cstring_to_text(...)` 
usages and I didn't found anything that seems suspicious.

Tests are also passing.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com