Message-ID: <a99a7ccc88e2939b047845230a55fe02528b4e7c.camel@j-davis.com>
Subject: Re: Do we still need MULE_INTERNAL?
From: Jeff Davis <pgsql@j-davis.com>
To: Thomas Munro <thomas.munro@gmail.com>, Tatsuo Ishii
 <ishii@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 31 Mar 2026 14:34:28 -0700
In-Reply-To: 
 <CA+hUKGK4ZvZYNRC_W10dT2W6TYBY24q=B-EfKpUL50v2E3U6_w@mail.gmail.com>
References: 
	<CA+hUKGKXDXh-FdU0orjfv+F08f=D91BhV3Ra-4zL-q+JmGYqTA@mail.gmail.com>
	 <20260211.155236.1457492817322202220.ishii@postgresql.org>
	 <CA+hUKGK4ZvZYNRC_W10dT2W6TYBY24q=B-EfKpUL50v2E3U6_w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1.1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/a99a7ccc88e2939b047845230a55fe02528b4e7c.camel%40j-davis.com>
Precedence: bulk

On Thu, 2026-02-12 at 03:06 +1300, Thomas Munro wrote:
> On Wed, Feb 11, 2026 at 7:52=E2=80=AFPM Tatsuo Ishii <ishii@postgresql.or=
g>
> wrote:
> > Thank you for the report. I find it is quite useful, especially the
> > Emacs 23 internal (new to me). I agree that MULE_INTERNAL has
> > fulfilled its historic role.
>=20
> Thanks Ishii-san and Tom.=C2=A0 Here's a patch.=C2=A0 Obviously it mostly=
 just
> deletes thousands of lines, but also: I had to preserve the encoding
> number, so there's a hole in the table,=C2=A0

pg_upgrade fails:

  Performing Upgrade
  ------------------
  ...
  Setting frozenxid and minmxid counters in new cluster       =20
connection to server on socket "/.../.s.PGSQL.50432" failed: FATAL:=20
invalid database encoding: 7

You should have an explicit check.

Other than that, it looks good to me.

> and I had to think of a new
> name for cyrillic_and_mic.c, so I went with cyrillic.c because it
> handles 4 single-byte encodings and it wasn't clear how to fit into
> the existing x_and_y pattern (ie which two to highlight arbitrarily
> in
> the name).

Seems fine.

Regards,
	Jeff Davis