Message-ID: <a9a26eb0-f8c3-0fbd-b7aa-f789da39d189@highgo.ca>
Date: Mon, 13 Mar 2023 14:30:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.7.2
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <EBE6C507-9EB6-4142-9E4D-38B1673363A7@amazon.com>
 <ZABP6zdfymC0QKDX@paquier.xyz>
 <9B9BB0F2-68A3-44E0-946E-3D9051F83369@amazon.com>
 <3499c5ed-5511-0801-ccfe-297b098aa8fe@highgo.ca>
 <E35AF94E-E050-471D-8A0C-4845811D9C74@amazon.com>
 <ZA0/oM2k2UUOpkLw@paquier.xyz>
From: David Zhang <david.zhang@highgo.ca>
In-Reply-To: <ZA0/oM2k2UUOpkLw@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a9a26eb0-f8c3-0fbd-b7aa-f789da39d189%40highgo.ca>
Precedence: bulk

>> It appears you must "make clean; make install" to correctly compile after
>> applying the patch.
> In a git repository, I've learnt to rely on this simple formula, even
> if it means extra cycles when running ./configure:
> git clean -d -x -f
>
Thank you all for pointing out that it needs make clean first. After 
make clean followed by recompile with the patch then both make check 
from regression test and pg_stat_statements extension report all test 
passed. So the current existing test cases can't really detect any 
change from this patch, then it would be better to add some test cases 
to cover this.

Best regards,

David