Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWHjO-0003Ap-2q for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Mar 2022 13:05:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWHjM-0000Fc-KK for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Mar 2022 13:05:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWHjL-0000FT-MS for pgsql-hackers@lists.postgresql.org; Mon, 21 Mar 2022 13:05:52 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWHjG-0006tR-Dt for pgsql-hackers@lists.postgresql.org; Mon, 21 Mar 2022 13:05:51 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2B22B5C018D; Mon, 21 Mar 2022 09:05:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 21 Mar 2022 09:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=saOvz28KmMM7sUKZ0/QxKx+Cz4u0ilcdaDHcAo8cB CM=; b=jy1Zuv2wS+wwxfiMNwfY6fvgYgPKNcdIk6fd8DVsEpDSftdmbrH78+m2M pqB6mdtMxaOYIDu5ZWUiYIEU3unIKjcMICT76znARrmz5yPcj/yAlKhzGX+d8Iw8 kba6jv50zGr+E/nMu3kPTlHo1HXjtaM1a9JdqgryEvCMSGHpkamXiyGadGdpdglV Sxv6MlZazVAaoURsK62c+6gGR9XeHzKvvxj3rHw6t2nrgRbzey8/7OP1frOuR9TE nxNWf7GyguaGqcV5y7nd2gbDsTqsb4Qa3SXZqskhS9HJzUXIjiCKbupx8opeva/p j2x6uA3XpMyE8FBmC6EioyWjc8Fvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegfedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepfeejgeehteeuhfevvedu leeufedtjeetiefftedvudfhtdeifefgueettdevgefgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Mar 2022 09:05:41 -0400 (EDT) Message-ID: Date: Mon, 21 Mar 2022 14:05:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: logical decoding and replication of sequences Content-Language: en-US To: Tomas Vondra Cc: Amit Kapila , PostgreSQL Hackers , Petr Jelinek References: <3B014BE4-EE61-4834-8FF6-937B43C46BC7@enterprisedb.com> <3d68b45a-ceb5-6824-3a39-f53411fd0c88@enterprisedb.com> <802f8b1b-a798-be52-c829-7f0fb9faafd5@enterprisedb.com> <983bf0c7-9757-fd13-3896-8452cf4c4c52@enterprisedb.com> <9211312a-6501-1caf-ee7b-c0d4814b6091@enterprisedb.com> <41ada110-bc7c-32a3-08bd-fb5023dd74ba@enterprisedb.com> <2eed0f76-3a1a-8b8b-ac1b-e0f9a0d98287@enterprisedb.com> <9defb937-20a9-1d9f-6972-f1c4b4da4f73@enterprisedb.com> <8e766e0f-ed3e-fd68-4b0f-10dd2db60c88@enterprisedb.com> <6b21233e-c880-e4ad-5df2-7832f769296c@enterprisedb.com> <9da788c7-01eb-f11d-aa08-c5f61fe9f33a@enterprisedb.com> From: Peter Eisentraut In-Reply-To: <9da788c7-01eb-f11d-aa08-c5f61fe9f33a@enterprisedb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 20.03.22 23:55, Tomas Vondra wrote: > Attached is a rebased patch, addressing most of the remaining issues. This looks okay to me, if the two FIXMEs are addressed. Remember to also update protocol.sgml if you change LOGICAL_REP_MSG_SEQUENCE.