Date: Wed, 23 Apr 2025 11:28:57 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>
Cc: jian he <jian.universality@gmail.com>,
	Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
	Robert Treat <rob@xzilla.net>, pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD
 COLUMN
Message-ID: <aAkVSY7pGg4SxSNp@nathan>
References: 
 <CACJufxGLcbFVS8xAC9OBPn0U_2YjKOiHLdmBrtds1j=5eA5MMA@mail.gmail.com>
 <202503241037.pjpyt5j7xrfs@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202503241037.pjpyt5j7xrfs@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/aAkVSY7pGg4SxSNp%40nathan>
Precedence: bulk

This one was briefly discussed in an RMT meeting.

On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote:
> On 2025-Mar-24, jian he wrote:
> 
>> In the current development branch,
>> virtual generated columns still do not support the domain.
>> you can not change the generation expression if it contains a check
>> constraint on it.
>> so virtual generated columns don't need rewriting.
>> 
>> IMHO, the committed doc description didn't mention this exception.
>> we need some text to cover this exception?
> 
> I'd add a note about these two things to the open items page, and wait
> to see if we get some of these limitations fixed, so that if we don't,
> we remember to note this limitation in the documentation.

Are we still waiting on something for this, or should we proceed with the
documentation changes?  It doesn't seem tremendously urgent, but I noticed
it's been about a month since the last message on this thread.

-- 
nathan