Date: Wed, 23 Apr 2025 16:44:51 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nisha Moond <nisha.moond412@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	Michael Paquier <michael@paquier.xyz>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Message-ID: <aAlfU06XTChyIGBD@nathan>
References: <4c2a6100-738e-48cc-8a11-2d85f95ae0ed@app.fastmail.com>
 <Z_X1jfsMrBBNUx4n@paquier.xyz>
 <Z_bFDNzcqWxatpL-@nathan>
 <18a111db-9f31-449c-a14b-61779a69f344@app.fastmail.com>
 <Z_mHvqVyGjEZhzl7@nathan>
 <aAZqiKRhUv7-fSpQ@nathan>
 <CABdArM6j03AAX5A2B9TPCZrY1xr+eFpGpzfdOBAww7mZnniUFg@mail.gmail.com>
 <aAfP_bitjVC1bcNV@nathan>
 <aAla1fg-1vPeXNck@nathan>
 <1503201.1745444021@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1503201.1745444021@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aAlfU06XTChyIGBD%40nathan>
Precedence: bulk

On Wed, Apr 23, 2025 at 05:33:41PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> Here is a new version of the patch with this change.
> 
> I don't see any comments in this patch that capture the real
> reason for removing pg_replication_origin's TOAST table,
> namely (IIUC) that we'd like to be able to access that catalog
> without a snapshot.  I think it's important to record that
> knowledge, because otherwise somebody is likely to think they
> can undo this change for $whatever-reason.

D'oh, yes, I'd better add that.

-- 
nathan